[PATCH] net: Remove ndo_dfwd_start_xmit

Looks like commit f663dd9aaf9e ("net: core: explicitly select a txq before doing l2 forwarding")
has removed the need for this dedicated xmit function [it even explicitly
states so in its commit log message] but it hasn't removed the definition
of the ndo.

Signed-off-by: Yuval Mintz <redacted>
CC: Jason Wang <redacted>
CC: John Fastabend <redacted>
---
 include/linux/netdevice.h | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 68f5d89..85f01d6 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h

@@ -1114,12 +1114,6 @@ struct xfrmdev_ops {
  *	by 'ndo_dfwd_add_station'. 'pdev' is the net device backing
  *	the station and priv is the structure returned by the add
  *	operation.
- * netdev_tx_t (*ndo_dfwd_start_xmit)(struct sk_buff *skb,
- *				      struct net_device *dev,
- *				      void *priv);
- *	Callback to use for xmit over the accelerated station. This
- *	is used in place of ndo_start_xmit on accelerated net
- *	devices.
  * int (*ndo_set_tx_maxrate)(struct net_device *dev,
  *			     int queue_index, u32 maxrate);
  *	Called when a user wants to set a max-rate limitation of specific

@@ -1316,9 +1310,6 @@ struct net_device_ops {
 	void			(*ndo_dfwd_del_station)(struct net_device *pdev,
 							void *priv);
 
-	netdev_tx_t		(*ndo_dfwd_start_xmit) (struct sk_buff *skb,
-							struct net_device *dev,
-							void *priv);
 	int			(*ndo_get_lock_subclass)(struct net_device *dev);
 	int			(*ndo_set_tx_maxrate)(struct net_device *dev,
 						      int queue_index,

-- 
2.9.4

From: Yuval Mintz <redacted>
Date: Sun, 25 Jun 2017 11:09:12 +0300

Looks like commit f663dd9aaf9e ("net: core: explicitly select a txq before doing l2 forwarding")
has removed the need for this dedicated xmit function [it even explicitly
states so in its commit log message] but it hasn't removed the definition
of the ndo.

Signed-off-by: Yuval Mintz <redacted>

Looks good, applied, thanks.

quoted

Looks like commit f663dd9aaf9e ("net: core: explicitly select a txq
before doing l2 forwarding") has removed the need for this dedicated
xmit function [it even explicitly states so in its commit log message]
but it hasn't removed the definition of the ndo.

Signed-off-by: Yuval Mintz <redacted>

Looks good, applied, thanks.

BTW, I've came across this while looking at ndo_dfwd_(add|del)_station,
but it Seems to me like there are simply not enough notification points to
reliably base the macvlan network-topology on in the offloader view.

Specifically, in case there is a mix of private/bridge macvlan instances
over a single lower-device, I can't see how the offloader could know and
prevent packets from being internally routed to the private instances.

Could someone perhaps clarify it a bit?