[PATCH] drivers: net: cpsw-common: Fix reading of mac address for am43 SoCs

Subsystems: networking drivers, the rest, ti ethernet switch driver (cpsw)

STALE3406d REVIEWED: 1 (0M)

1 review trailer.

2 messages, 2 authors, 2017-06-22 · open the first message on its own page

[PATCH] drivers: net: cpsw-common: Fix reading of mac address for am43 SoCs

From: Lokesh Vutla <hidden>
Date: 2017-06-21 08:45:27

cpsw driver tries to get macid for am43xx SoCs using the compatible
ti,am4372. But not all variants of am43x uses this complatible like
epos evm uses ti,am438x. So use a generic compatible ti,am43 to get
macid for all am43 based platforms.

Reviewed-by: Dave Gerlach <redacted>
Signed-off-by: Lokesh Vutla <redacted>
---
 drivers/net/ethernet/ti/cpsw-common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/cpsw-common.c b/drivers/net/ethernet/ti/cpsw-common.c
index 1562ab4151e1..56ba411421f0 100644
--- a/drivers/net/ethernet/ti/cpsw-common.c
+++ b/drivers/net/ethernet/ti/cpsw-common.c
@@ -90,7 +90,7 @@ int ti_cm_get_macid(struct device *dev, int slave, u8 *mac_addr)
 	if (of_device_is_compatible(dev->of_node, "ti,dm816-emac"))
 		return cpsw_am33xx_cm_get_macid(dev, 0x30, slave, mac_addr);
 
-	if (of_machine_is_compatible("ti,am4372"))
+	if (of_machine_is_compatible("ti,am43"))
 		return cpsw_am33xx_cm_get_macid(dev, 0x630, slave, mac_addr);
 
 	if (of_machine_is_compatible("ti,dra7"))
-- 
2.13.0

Re: [PATCH] drivers: net: cpsw-common: Fix reading of mac address for am43 SoCs

From: David Miller <davem@davemloft.net>
Date: 2017-06-22 15:16:38

From: Lokesh Vutla <redacted>
Date: Wed, 21 Jun 2017 14:12:04 +0530
cpsw driver tries to get macid for am43xx SoCs using the compatible
ti,am4372. But not all variants of am43x uses this complatible like
epos evm uses ti,am438x. So use a generic compatible ti,am43 to get
macid for all am43 based platforms.

Reviewed-by: Dave Gerlach <redacted>
Signed-off-by: Lokesh Vutla <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help