[PATCH net-next] liquidio: fix VF driver off-by-one bug when setting ethtool -C ethX rx-frames

Subsystems: cavium liquidio network driver, networking drivers, the rest

STALE3418d

2 messages, 2 authors, 2017-06-14 · open the first message on its own page

[PATCH net-next] liquidio: fix VF driver off-by-one bug when setting ethtool -C ethX rx-frames

From: Felix Manlunas <hidden>
Date: 2017-06-14 16:11:41

From: Weilin Chang <redacted>

Signed-off-by: Weilin Chang <redacted>
Signed-off-by: Derek Chickles <redacted>
Signed-off-by: Felix Manlunas <redacted>
---
 drivers/net/ethernet/cavium/liquidio/lio_ethtool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c b/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c
index 53856af..28ecda3 100644
--- a/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c
+++ b/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c
@@ -1808,7 +1808,7 @@ oct_cfg_rx_intrcnt(struct lio *lio,
 			    (octeon_read_csr64(
 				 oct, CN23XX_VF_SLI_OQ_PKT_INT_LEVELS(q_no)) &
 			     (0x3fffff00000000UL)) |
-				rx_max_coalesced_frames);
+				(rx_max_coalesced_frames - 1));
 			/*consider writing to resend bit here*/
 		}
 		intrmod->rx_frames = rx_max_coalesced_frames;

Re: [PATCH net-next] liquidio: fix VF driver off-by-one bug when setting ethtool -C ethX rx-frames

From: David Miller <davem@davemloft.net>
Date: 2017-06-14 19:43:01

From: Felix Manlunas <redacted>
Date: Wed, 14 Jun 2017 09:11:31 -0700
From: Weilin Chang <redacted>

Signed-off-by: Weilin Chang <redacted>
Signed-off-by: Derek Chickles <redacted>
Signed-off-by: Felix Manlunas <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help