[net-next] fjes: remove duplicate set of flag IFF_BROADCAST

Subsystems: networking drivers, the rest

3 messages, 3 authors, 2017-06-13 · open the first message on its own page

[net-next] fjes: remove duplicate set of flag IFF_BROADCAST

From: Zhang Shengju <hidden>
Date: 2017-06-13 12:49:58

Remove unnecessary set of flag IFF_BROADCAST, since ether_setup
already does this.

Signed-off-by: Zhang Shengju <redacted>
---
 drivers/net/fjes/fjes_main.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c
index ae48c80..b56e07f 100644
--- a/drivers/net/fjes/fjes_main.c
+++ b/drivers/net/fjes/fjes_main.c
@@ -1348,7 +1348,6 @@ static void fjes_netdev_setup(struct net_device *netdev)
 	netdev->mtu = fjes_support_mtu[3];
 	netdev->min_mtu = fjes_support_mtu[0];
 	netdev->max_mtu = fjes_support_mtu[3];
-	netdev->flags |= IFF_BROADCAST;
 	netdev->features |= NETIF_F_HW_VLAN_CTAG_FILTER;
 }
 
-- 
1.8.3.1

Re: [net-next] fjes: remove duplicate set of flag IFF_BROADCAST

From: Sergei Shtylyov <hidden>
Date: 2017-06-13 15:55:12

Hello!

On 06/13/2017 03:49 PM, Zhang Shengju wrote:
Remove unnecessary set of flag IFF_BROADCAST, since ether_setup
   s/set/setting/. Perhaps can be fixed while applying...
already does this.

Signed-off-by: Zhang Shengju <redacted>
[...]

MBR, Sergei

Re: [net-next] fjes: remove duplicate set of flag IFF_BROADCAST

From: David Miller <davem@davemloft.net>
Date: 2017-06-13 17:55:06

From: Zhang Shengju <redacted>
Date: Tue, 13 Jun 2017 20:49:49 +0800
Remove unnecessary set of flag IFF_BROADCAST, since ether_setup
already does this.

Signed-off-by: Zhang Shengju <redacted>
Applied with commit log message fixed, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help