[net-next,v2] openvswitch: add macro MODULE_ALIAS_VPORT_TYPE for vport type alias

Subsystems: networking [general], openvswitch, the rest

3 messages, 3 authors, 2017-06-14 · open the first message on its own page

[net-next,v2] openvswitch: add macro MODULE_ALIAS_VPORT_TYPE for vport type alias

From: Zhang Shengju <hidden>
Date: 2017-06-13 07:01:11

Add a new macro MODULE_ALIAS_VPORT_TYPE to unify and simplify the
declaration of vport type alias.

Signed-off-by: Zhang Shengju <redacted>
---
 net/openvswitch/vport-geneve.c | 2 +-
 net/openvswitch/vport-gre.c    | 2 +-
 net/openvswitch/vport-vxlan.c  | 2 +-
 net/openvswitch/vport.h        | 3 +++
 4 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/net/openvswitch/vport-geneve.c b/net/openvswitch/vport-geneve.c
index 5aaf3ba..0ebf023 100644
--- a/net/openvswitch/vport-geneve.c
+++ b/net/openvswitch/vport-geneve.c

@@ -141,4 +141,4 @@ static void __exit ovs_geneve_tnl_exit(void)
 
 MODULE_DESCRIPTION("OVS: Geneve switching port");
 MODULE_LICENSE("GPL");
-MODULE_ALIAS("vport-type-5");
+MODULE_ALIAS_VPORT_TYPE(5);

diff --git a/net/openvswitch/vport-gre.c b/net/openvswitch/vport-gre.c
index 0e72d95..97fc4d5 100644
--- a/net/openvswitch/vport-gre.c
+++ b/net/openvswitch/vport-gre.c

@@ -113,4 +113,4 @@ static void __exit ovs_gre_tnl_exit(void)
 
 MODULE_DESCRIPTION("OVS: GRE switching port");
 MODULE_LICENSE("GPL");
-MODULE_ALIAS("vport-type-3");
+MODULE_ALIAS_VPORT_TYPE(3);

diff --git a/net/openvswitch/vport-vxlan.c b/net/openvswitch/vport-vxlan.c
index 869acb3..0375b6a 100644
--- a/net/openvswitch/vport-vxlan.c
+++ b/net/openvswitch/vport-vxlan.c

@@ -179,4 +179,4 @@ static void __exit ovs_vxlan_tnl_exit(void)
 
 MODULE_DESCRIPTION("OVS: VXLAN switching port");
 MODULE_LICENSE("GPL");
-MODULE_ALIAS("vport-type-4");
+MODULE_ALIAS_VPORT_TYPE(4);

diff --git a/net/openvswitch/vport.h b/net/openvswitch/vport.h
index cda66c2..1d1584f 100644
--- a/net/openvswitch/vport.h
+++ b/net/openvswitch/vport.h

@@ -199,4 +199,7 @@ static inline const char *ovs_vport_name(struct vport *vport)
 void ovs_vport_ops_unregister(struct vport_ops *ops);
 void ovs_vport_send(struct vport *vport, struct sk_buff *skb, u8 mac_proto);
 
+#define MODULE_ALIAS_VPORT_TYPE(type) \
+	MODULE_ALIAS("vport-type-" __stringify(type))
+
 #endif /* vport.h */

-- 
1.8.3.1

Re: [net-next,v2] openvswitch: add macro MODULE_ALIAS_VPORT_TYPE for vport type alias

From: David Miller <davem@davemloft.net>
Date: 2017-06-14 18:34:16

From: Zhang Shengju <redacted>
Date: Tue, 13 Jun 2017 15:00:57 +0800

Add a new macro MODULE_ALIAS_VPORT_TYPE to unify and simplify the
declaration of vport type alias.

Signed-off-by: Zhang Shengju <redacted>

Openvswitch folks, please review.

Re: [net-next,v2] openvswitch: add macro MODULE_ALIAS_VPORT_TYPE for vport type alias

From: Pravin Shelar <hidden>
Date: 2017-06-14 20:43:13

On Tue, Jun 13, 2017 at 12:00 AM, Zhang Shengju
[off-list ref] wrote:

Add a new macro MODULE_ALIAS_VPORT_TYPE to unify and simplify the
declaration of vport type alias.

Signed-off-by: Zhang Shengju <redacted>
---
 net/openvswitch/vport-geneve.c | 2 +-
 net/openvswitch/vport-gre.c    | 2 +-
 net/openvswitch/vport-vxlan.c  | 2 +-
 net/openvswitch/vport.h        | 3 +++
 4 files changed, 6 insertions(+), 3 deletions(-)

The change looks fine. But I do not see value in it. This is compat
tunnel code, there should not be any more vports added to OVS. So
adding this new API does not help for future code changes either.

quoted hunk

diff --git a/net/openvswitch/vport-geneve.c b/net/openvswitch/vport-geneve.c
index 5aaf3ba..0ebf023 100644
--- a/net/openvswitch/vport-geneve.c
+++ b/net/openvswitch/vport-geneve.c

@@ -141,4 +141,4 @@ static void __exit ovs_geneve_tnl_exit(void)

 MODULE_DESCRIPTION("OVS: Geneve switching port");
 MODULE_LICENSE("GPL");
-MODULE_ALIAS("vport-type-5");
+MODULE_ALIAS_VPORT_TYPE(5);

diff --git a/net/openvswitch/vport-gre.c b/net/openvswitch/vport-gre.c
index 0e72d95..97fc4d5 100644
--- a/net/openvswitch/vport-gre.c
+++ b/net/openvswitch/vport-gre.c

@@ -113,4 +113,4 @@ static void __exit ovs_gre_tnl_exit(void)

 MODULE_DESCRIPTION("OVS: GRE switching port");
 MODULE_LICENSE("GPL");
-MODULE_ALIAS("vport-type-3");
+MODULE_ALIAS_VPORT_TYPE(3);

diff --git a/net/openvswitch/vport-vxlan.c b/net/openvswitch/vport-vxlan.c
index 869acb3..0375b6a 100644
--- a/net/openvswitch/vport-vxlan.c
+++ b/net/openvswitch/vport-vxlan.c

@@ -179,4 +179,4 @@ static void __exit ovs_vxlan_tnl_exit(void)

 MODULE_DESCRIPTION("OVS: VXLAN switching port");
 MODULE_LICENSE("GPL");
-MODULE_ALIAS("vport-type-4");
+MODULE_ALIAS_VPORT_TYPE(4);

diff --git a/net/openvswitch/vport.h b/net/openvswitch/vport.h
index cda66c2..1d1584f 100644
--- a/net/openvswitch/vport.h
+++ b/net/openvswitch/vport.h

@@ -199,4 +199,7 @@ static inline const char *ovs_vport_name(struct vport *vport)
 void ovs_vport_ops_unregister(struct vport_ops *ops);
 void ovs_vport_send(struct vport *vport, struct sk_buff *skb, u8 mac_proto);

+#define MODULE_ALIAS_VPORT_TYPE(type) \
+       MODULE_ALIAS("vport-type-" __stringify(type))
+
 #endif /* vport.h */
--

1.8.3.1

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help