[PATCH net-next] Remove the redundant skb->dev initialization in ip6_fragment

Subsystems: networking [general], networking [ipv4/ipv6], the rest

STALE3424d

2 messages, 2 authors, 2017-06-10 · open the first message on its own page

[PATCH net-next] Remove the redundant skb->dev initialization in ip6_fragment

From: Chenbo Feng <hidden>
Date: 2017-06-10 19:35:46

From: Chenbo Feng <redacted>

After moves the skb->dev and skb->protocol initialization into
ip6_output, setting the skb->dev inside ip6_fragment is unnecessary.

Fixes: 97a7a37a7b7b("ipv6: Initial skb->dev and skb->protocol in ip6_output")
Signed-off-by: Chenbo Feng <redacted>
---
 net/ipv6/ip6_output.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c
index 02cd44f..0d6f3b6 100644
--- a/net/ipv6/ip6_output.c
+++ b/net/ipv6/ip6_output.c
@@ -869,7 +869,6 @@ int ip6_fragment(struct net *net, struct sock *sk, struct sk_buff *skb,
 	if (skb->sk && dst_allfrag(skb_dst(skb)))
 		sk_nocaps_add(skb->sk, NETIF_F_GSO_MASK);
 
-	skb->dev = skb_dst(skb)->dev;
 	icmpv6_send(skb, ICMPV6_PKT_TOOBIG, 0, mtu);
 	err = -EMSGSIZE;
 
-- 
2.7.4

Re: [PATCH net-next] Remove the redundant skb->dev initialization in ip6_fragment

From: David Miller <davem@davemloft.net>
Date: 2017-06-10 20:25:54

From: Chenbo Feng <redacted>
Date: Sat, 10 Jun 2017 12:35:38 -0700
From: Chenbo Feng <redacted>

After moves the skb->dev and skb->protocol initialization into
ip6_output, setting the skb->dev inside ip6_fragment is unnecessary.

Fixes: 97a7a37a7b7b("ipv6: Initial skb->dev and skb->protocol in ip6_output")
Signed-off-by: Chenbo Feng <redacted>
Applied, thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help