[PATCH] net: fec: Add a fec_enet_clear_ethtool_stats() stub for CONFIG_M5272

Subsystems: freescale imx / mxc fec driver, networking drivers, the rest

STALE3417d

4 messages, 2 authors, 2017-06-10 · open the first message on its own page

[PATCH] net: fec: Add a fec_enet_clear_ethtool_stats() stub for CONFIG_M5272

From: Fabio Estevam <festevam@gmail.com>
Date: 2017-06-10 01:37:39

From: Fabio Estevam <redacted>

Commit 2b30842b23b9 ("net: fec: Clear and enable MIB counters on imx51")
introduced fec_enet_clear_ethtool_stats(), but missed to add a stub
for the CONFIG_M5272=y case, causing build failure for the
m5272c3_defconfig.

Add the missing empty stub to fix the build failure.

Reported-by: Paul Gortmaker <redacted>
Signed-off-by: Fabio Estevam <redacted>
---
 drivers/net/ethernet/freescale/fec_main.c | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 297fd19..a6e323f 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -2379,6 +2379,10 @@ static void fec_enet_clear_ethtool_stats(struct net_device *dev)
 static inline void fec_enet_update_ethtool_stats(struct net_device *dev)
 {
 }
+
+static inline void fec_enet_clear_ethtool_stats(struct net_device *dev)
+{
+}
 #endif /* !defined(CONFIG_M5272) */
 
 /* ITR clock source is enet system clock (clk_ahb).
-- 
2.7.4

Re: [PATCH] net: fec: Add a fec_enet_clear_ethtool_stats() stub for CONFIG_M5272

From: David Miller <davem@davemloft.net>
Date: 2017-06-10 20:16:51

From: Fabio Estevam <festevam@gmail.com>
Date: Fri,  9 Jun 2017 22:37:22 -0300
From: Fabio Estevam <redacted>

Commit 2b30842b23b9 ("net: fec: Clear and enable MIB counters on imx51")
introduced fec_enet_clear_ethtool_stats(), but missed to add a stub
for the CONFIG_M5272=y case, causing build failure for the
m5272c3_defconfig.

Add the missing empty stub to fix the build failure.

Reported-by: Paul Gortmaker <redacted>
Signed-off-by: Fabio Estevam <redacted>
Applied, thanks.

Re: [PATCH] net: fec: Add a fec_enet_clear_ethtool_stats() stub for CONFIG_M5272

From: Fabio Estevam <festevam@gmail.com>
Date: 2017-06-10 20:33:02

On Sat, Jun 10, 2017 at 5:16 PM, David Miller [off-list ref] wrote:
From: Fabio Estevam <festevam@gmail.com>
Date: Fri,  9 Jun 2017 22:37:22 -0300
quoted
From: Fabio Estevam <redacted>

Commit 2b30842b23b9 ("net: fec: Clear and enable MIB counters on imx51")
introduced fec_enet_clear_ethtool_stats(), but missed to add a stub
for the CONFIG_M5272=y case, causing build failure for the
m5272c3_defconfig.

Add the missing empty stub to fix the build failure.

Reported-by: Paul Gortmaker <redacted>
Signed-off-by: Fabio Estevam <redacted>
Applied, thanks.
I should have marked net-next in the Subject.

Commit 2b30842b23b9 ("net: fec: Clear and enable MIB counters on
imx51") is in net-next, so this one should go to net-next, not to net.

Sorry about that.

Re: [PATCH] net: fec: Add a fec_enet_clear_ethtool_stats() stub for CONFIG_M5272

From: David Miller <davem@davemloft.net>
Date: 2017-06-10 20:45:51

From: Fabio Estevam <festevam@gmail.com>
Date: Sat, 10 Jun 2017 17:33:01 -0300
On Sat, Jun 10, 2017 at 5:16 PM, David Miller [off-list ref] wrote:
quoted
From: Fabio Estevam <festevam@gmail.com>
Date: Fri,  9 Jun 2017 22:37:22 -0300
quoted
From: Fabio Estevam <redacted>

Commit 2b30842b23b9 ("net: fec: Clear and enable MIB counters on imx51")
introduced fec_enet_clear_ethtool_stats(), but missed to add a stub
for the CONFIG_M5272=y case, causing build failure for the
m5272c3_defconfig.

Add the missing empty stub to fix the build failure.

Reported-by: Paul Gortmaker <redacted>
Signed-off-by: Fabio Estevam <redacted>
Applied, thanks.
I should have marked net-next in the Subject.

Commit 2b30842b23b9 ("net: fec: Clear and enable MIB counters on
imx51") is in net-next, so this one should go to net-next, not to net.

Sorry about that.
Ok, reverted from 'net' and applied to 'net-next' with an appropriate
Fixes: tag added.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help