[PATCH net] bnx2x: fix pf2vf bulletin DMA mapping leak

Subsystems: broadcom bnx2x 10 gigabit ethernet driver, networking drivers, the rest

STALE3426d

3 messages, 3 authors, 2017-06-07 · open the first message on its own page

[PATCH net] bnx2x: fix pf2vf bulletin DMA mapping leak

From: Michal Schmidt <hidden>
Date: 2017-06-06 14:30:53

When freeing VF's DMA mappings, an already NULLed pointer was checked
again due to an apparent copy&paste error. Consequently, the pf2vf
bulletin DMA mapping was not freed.

Signed-off-by: Michal Schmidt <redacted>
---
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
index bdfd53b46b..870ea001a7 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
@@ -3042,7 +3042,7 @@ void bnx2x_vf_pci_dealloc(struct bnx2x *bp)
 {
 	BNX2X_PCI_FREE(bp->vf2pf_mbox, bp->vf2pf_mbox_mapping,
 		       sizeof(struct bnx2x_vf_mbx_msg));
-	BNX2X_PCI_FREE(bp->vf2pf_mbox, bp->pf2vf_bulletin_mapping,
+	BNX2X_PCI_FREE(bp->pf2vf_bulletin, bp->pf2vf_bulletin_mapping,
 		       sizeof(union pf_vf_bulletin));
 }
 
-- 
2.13.0

RE: [PATCH net] bnx2x: fix pf2vf bulletin DMA mapping leak

From: Mintz, Yuval <hidden>
Date: 2017-06-07 14:23:42

When freeing VF's DMA mappings, an already NULLed pointer was checked
again due to an apparent copy&paste error. Consequently, the pf2vf bulletin
DMA mapping was not freed.

Signed-off-by: Michal Schmidt <redacted>
Thanks Michal.

Acked-by: Yuval Mintz <redacted>

Re: [PATCH net] bnx2x: fix pf2vf bulletin DMA mapping leak

From: David Miller <davem@davemloft.net>
Date: 2017-06-07 17:00:09

From: Michal Schmidt <redacted>
Date: Tue,  6 Jun 2017 16:30:31 +0200
When freeing VF's DMA mappings, an already NULLed pointer was checked
again due to an apparent copy&paste error. Consequently, the pf2vf
bulletin DMA mapping was not freed.

Signed-off-by: Michal Schmidt <redacted>
Applied, thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help