[PATCH] net/3com: Make el3_netdev_get_ecmd return void

Subsystems: 3c509 network driver, networking drivers, the rest

STALE3423d

2 messages, 2 authors, 2017-06-05 · open the first message on its own page

[PATCH] net/3com: Make el3_netdev_get_ecmd return void

From: Yuval Shaia <hidden>
Date: 2017-06-04 17:25:25

Make return value void since function never returns meaningfull value.

Signed-off-by: Yuval Shaia <redacted>
---
 drivers/net/ethernet/3com/3c509.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/3com/3c509.c b/drivers/net/ethernet/3com/3c509.c
index db8592d..f66c971 100644
--- a/drivers/net/ethernet/3com/3c509.c
+++ b/drivers/net/ethernet/3com/3c509.c
@@ -1039,7 +1039,7 @@ el3_link_ok(struct net_device *dev)
 	return tmp & (1<<11);
 }
 
-static int
+static void
 el3_netdev_get_ecmd(struct net_device *dev, struct ethtool_link_ksettings *cmd)
 {
 	u16 tmp;
@@ -1082,7 +1082,6 @@ el3_netdev_get_ecmd(struct net_device *dev, struct ethtool_link_ksettings *cmd)
 						supported);
 	cmd->base.speed = SPEED_10;
 	EL3WINDOW(1);
-	return 0;
 }
 
 static int
@@ -1151,12 +1150,11 @@ static int el3_get_link_ksettings(struct net_device *dev,
 				  struct ethtool_link_ksettings *cmd)
 {
 	struct el3_private *lp = netdev_priv(dev);
-	int ret;
 
 	spin_lock_irq(&lp->lock);
-	ret = el3_netdev_get_ecmd(dev, cmd);
+	el3_netdev_get_ecmd(dev, cmd);
 	spin_unlock_irq(&lp->lock);
-	return ret;
+	return 0;
 }
 
 static int el3_set_link_ksettings(struct net_device *dev,
-- 
2.9.4

Re: [PATCH] net/3com: Make el3_netdev_get_ecmd return void

From: David Miller <davem@davemloft.net>
Date: 2017-06-05 15:01:38

From: Yuval Shaia <redacted>
Date: Sun,  4 Jun 2017 20:24:46 +0300
Make return value void since function never returns meaningfull value.

Signed-off-by: Yuval Shaia <redacted>
Applied to net-next.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help