Re: [PATCH] net: wireless: ath: ath10k: remove unnecessary code

4 messages, 3 authors, 2017-05-09 · open the first message on its own page

Re: [PATCH] net: wireless: ath: ath10k: remove unnecessary code

From: Kalle Valo <hidden>
Date: 2017-05-09 05:33:35

"Gustavo A. R. Silva" [off-list ref] writes:
The name of an array used by itself will always return the array's address.
So these tests will always evaluate as false and therefore the _return_
will never be executed.

Signed-off-by: Gustavo A. R. Silva <redacted>
I don't understand the commit log, especially what does "The name of an
array used by itself" mean?

-- 
Kalle Valo

Re: [PATCH] net: wireless: ath: ath10k: remove unnecessary code

From: Arend Van Spriel <arend.vanspriel@broadcom.com>
Date: 2017-05-09 12:08:08

On 9-5-2017 7:33, Kalle Valo wrote:
"Gustavo A. R. Silva" [off-list ref] writes:
quoted
The name of an array used by itself will always return the array's address.
So these tests will always evaluate as false and therefore the _return_
will never be executed.

Signed-off-by: Gustavo A. R. Silva <redacted>
I don't understand the commit log, especially what does "The name of an
array used by itself" mean?
The array fields in struct wmi_start_scan_arg that are checked here are
fixed size arrays so they can never be NULL.

Maybe that helps rephrasing this commit message.

Regards,
Arend

Re: [PATCH] net: wireless: ath: ath10k: remove unnecessary code

From: Gustavo A. R. Silva <hidden>
Date: 2017-05-09 12:25:26

Hi Kalle,

Quoting Kalle Valo [off-list ref]:
"Gustavo A. R. Silva" [off-list ref] writes:
quoted
The name of an array used by itself will always return the array's address.
So these tests will always evaluate as false and therefore the _return_
will never be executed.

Signed-off-by: Gustavo A. R. Silva <garsilva-L1vi/lXTdts+Va1GwOuvDg@public.gmane.org>
I don't understand the commit log, especially what does "The name of an
array used by itself" mean?
Let me correct that and I'll send the patch again.

Thanks!
--
Gustavo A. R. Silva

Re: [PATCH] net: wireless: ath: ath10k: remove unnecessary code

From: Gustavo A. R. Silva <hidden>
Date: 2017-05-09 12:57:02

Hi Arend,

Quoting Arend Van Spriel [off-list ref]:
On 9-5-2017 7:33, Kalle Valo wrote:
quoted
"Gustavo A. R. Silva" [off-list ref] writes:
quoted
The name of an array used by itself will always return the array's address.
So these tests will always evaluate as false and therefore the _return_
will never be executed.

Signed-off-by: Gustavo A. R. Silva <redacted>
I don't understand the commit log, especially what does "The name of an
array used by itself" mean?
The array fields in struct wmi_start_scan_arg that are checked here are
fixed size arrays so they can never be NULL.

Maybe that helps rephrasing this commit message.
Definitely. Thank you!
--
Gustavo A. R. Silva
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help