Re: [PATCH net-next 6/9] bpf: fix stack_depth usage by test_bpf.ko
From: David Miller <davem@davemloft.net>
Date: 2017-05-31 18:43:22
From: David Miller <davem@davemloft.net>
Date: 2017-05-31 18:43:22
From: Alexei Starovoitov <redacted> Date: Wed, 31 May 2017 11:39:37 -0700
On 5/31/17 11:15 AM, David Miller wrote:quoted
From: Alexei Starovoitov <redacted> Date: Tue, 30 May 2017 13:31:32 -0700quoted
test_bpf.ko doesn't call verifier before selecting interpreter or JITing, hence the tests need to manually specify the amount of stack they consume. Signed-off-by: Alexei Starovoitov <ast@kernel.org> Acked-by: Daniel Borkmann <daniel@iogearbox.net>I do not like this and the previous patch, it seems so error prone.in what sense 'error prone' ?
In the sense that a human computes these numbers, and nothing checks if it is correct or not until program perhaps crashes if the value is wrong.