[PATCH] drop_monitor: use setup_timer

Subsystems: network drop monitor, networking [general], the rest

STALE3398d

2 messages, 2 authors, 2017-03-13 · open the first message on its own page

[PATCH] drop_monitor: use setup_timer

From: Geliang Tang <hidden>
Date: 2017-03-11 00:47:50

Use setup_timer() instead of init_timer() to simplify the code.

Signed-off-by: Geliang Tang <redacted>
---
 net/core/drop_monitor.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/net/core/drop_monitor.c b/net/core/drop_monitor.c
index fb55327..70ccda2 100644
--- a/net/core/drop_monitor.c
+++ b/net/core/drop_monitor.c
@@ -412,9 +412,8 @@ static int __init init_net_drop_monitor(void)
 	for_each_possible_cpu(cpu) {
 		data = &per_cpu(dm_cpu_data, cpu);
 		INIT_WORK(&data->dm_alert_work, send_dm_alert);
-		init_timer(&data->send_timer);
-		data->send_timer.data = (unsigned long)data;
-		data->send_timer.function = sched_send_work;
+		setup_timer(&data->send_timer, sched_send_work,
+			    (unsigned long)data);
 		spin_lock_init(&data->lock);
 		reset_per_cpu_data(data);
 	}
-- 
2.9.3

Re: [PATCH] drop_monitor: use setup_timer

From: David Miller <davem@davemloft.net>
Date: 2017-03-13 06:48:14

From: Geliang Tang <redacted>
Date: Sat, 11 Mar 2017 08:46:59 +0800
Use setup_timer() instead of init_timer() to simplify the code.

Signed-off-by: Geliang Tang <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help