[PATCH] ambassador: use setup_timer

Subsystems: atm, the rest

STALE3392d

2 messages, 2 authors, 2017-03-13 · open the first message on its own page

[PATCH] ambassador: use setup_timer

From: Geliang Tang <hidden>
Date: 2017-03-11 00:47:29

Use setup_timer() instead of init_timer() to simplify the code.

Signed-off-by: Geliang Tang <redacted>
---
 drivers/atm/ambassador.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassador.c
index 4a61079..906705e 100644
--- a/drivers/atm/ambassador.c
+++ b/drivers/atm/ambassador.c
@@ -2267,9 +2267,8 @@ static int amb_probe(struct pci_dev *pci_dev,
 	dev->atm_dev->ci_range.vpi_bits = NUM_VPI_BITS;
 	dev->atm_dev->ci_range.vci_bits = NUM_VCI_BITS;
 
-	init_timer(&dev->housekeeping);
-	dev->housekeeping.function = do_housekeeping;
-	dev->housekeeping.data = (unsigned long) dev;
+	setup_timer(&dev->housekeeping, do_housekeeping,
+		    (unsigned long)dev);
 	mod_timer(&dev->housekeeping, jiffies);
 
 	// enable host interrupts
-- 
2.9.3

Re: [PATCH] ambassador: use setup_timer

From: David Miller <davem@davemloft.net>
Date: 2017-03-13 06:48:00

From: Geliang Tang <redacted>
Date: Sat, 11 Mar 2017 08:46:56 +0800
Use setup_timer() instead of init_timer() to simplify the code.

Signed-off-by: Geliang Tang <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help