# Re: \[PATCH 11/29\] drivers, media: convert cx88\_core.refcount from atomic\_t to refcount\_t

- From: Sergei Shtylyov \<hidden\>
- Date: 2017-03-07 10:50:44 
- List: netdev
- Page: https://ratatoskr.run/netdev/2017/03/4948110
- Thread: https://ratatoskr.run/netdev/2017/03/4947373/t.md

```text
On 3/7/2017 10:52 AM, Reshetova, Elena wrote:

>>> refcount_t type and corresponding API should be
>>> used instead of atomic_t when the variable is used as
>>> a reference counter. This allows to avoid accidental
>>> refcounter overflows that might lead to use-after-free
>>> situations.
>>>
>>> Signed-off-by: Elena Reshetova <elena.reshetova@intel.com>
>>> Signed-off-by: Hans Liljestrand <redacted>
>>> Signed-off-by: Kees Cook <redacted>
>>> Signed-off-by: David Windsor <redacted>
>> [...]
>>> diff --git a/drivers/media/pci/cx88/cx88.h b/drivers/media/pci/cx88/cx88.h
>>> index 115414c..16c1313 100644
>>> --- a/drivers/media/pci/cx88/cx88.h
>>> +++ b/drivers/media/pci/cx88/cx88.h
[...]
>>> @@ -339,7 +340,7 @@ struct cx8802_dev;
>>>
>>>  struct cx88_core {
>>>  	struct list_head           devlist;
>>> -	atomic_t                   refcount;
>>> +	refcount_t                   refcount;
>>
>>     Could you please keep the name aligned with above and below?
>
> You mean "not aligned" to devlist, but with a shift like it was before?

   I mean aligned, like it was before. :-)

> Sure, will fix. Is the patch ok otherwise?

   I haven't noticed anything else...

> Best Regards,
> Elena.
[...]

MBR, Sergei
```
