net/sched: act_skbmod: rcu_read_unlock in tcf_skbmod_dump?

Hello!

rcu_read_unlock() in tcf_skbmod_dump() looks suspicious to me.
What does it mean there?

On 17-03-04 03:49 PM, Alexey Khoroshilov wrote:

Hello!

rcu_read_unlock() in tcf_skbmod_dump() looks suspicious to me.

It does look suspicious. You want to send a patch or should I?

cheers,
jamal

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <redacted>
---
 net/sched/act_skbmod.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/sched/act_skbmod.c b/net/sched/act_skbmod.c
index 3b7074e23024..c736627f8f4a 100644
--- a/net/sched/act_skbmod.c
+++ b/net/sched/act_skbmod.c

@@ -228,7 +228,6 @@ static int tcf_skbmod_dump(struct sk_buff *skb, struct tc_action *a,
 
 	return skb->len;
 nla_put_failure:
-	rcu_read_unlock();
 	nlmsg_trim(skb, b);
 	return -1;
 }

-- 
2.7.4

On 17-03-04 07:01 PM, Alexey Khoroshilov wrote:

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <redacted>

Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>

cheers,
jamal

From: Alexey Khoroshilov <redacted>
Date: Sun,  5 Mar 2017 03:01:55 +0300

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <redacted>

Applied and queued up for -stable, thanks.