[PATCH net-next] net: bfin_mac: Remove unused stats member from struct bfin_mac_local

Subsystems: networking drivers, the rest

STALE3420d

2 messages, 2 authors, 2017-03-27 · open the first message on its own page

[PATCH net-next] net: bfin_mac: Remove unused stats member from struct bfin_mac_local

From: Tobias Klauser <tklauser@distanz.ch>
Date: 2017-03-27 06:55:35

The bfin_mac driver keeps its statistics in net_device->stats, so the
stats member in struct bfin_mac_local is unused. Remove it, as well as
the accompanying comment.

Cc: adi-buildroot-devel@lists.sourceforge.net
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
 drivers/net/ethernet/adi/bfin_mac.h | 7 -------
 1 file changed, 7 deletions(-)
diff --git a/drivers/net/ethernet/adi/bfin_mac.h b/drivers/net/ethernet/adi/bfin_mac.h
index 8c3b56198e4b..4ad5b9be3f84 100644
--- a/drivers/net/ethernet/adi/bfin_mac.h
+++ b/drivers/net/ethernet/adi/bfin_mac.h
@@ -68,13 +68,6 @@ struct net_dma_desc_tx {
 };
 
 struct bfin_mac_local {
-	/*
-	 * these are things that the kernel wants me to keep, so users
-	 * can find out semi-useless statistics of how well the card is
-	 * performing
-	 */
-	struct net_device_stats stats;
-
 	spinlock_t lock;
 
 	int wol;		/* Wake On Lan */
-- 
2.11.0

Re: [PATCH net-next] net: bfin_mac: Remove unused stats member from struct bfin_mac_local

From: David Miller <davem@davemloft.net>
Date: 2017-03-27 23:02:27

From: Tobias Klauser <tklauser@distanz.ch>
Date: Mon, 27 Mar 2017 08:55:11 +0200
The bfin_mac driver keeps its statistics in net_device->stats, so the
stats member in struct bfin_mac_local is unused. Remove it, as well as
the accompanying comment.

Cc: adi-buildroot-devel@lists.sourceforge.net
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help