[PATCH net v3 1/1] net: tcp: Permit user set TCP_MAXSEG to default value

Subsystems: networking [general], networking [tcp], the rest

STALE3421d

2 messages, 2 authors, 2017-03-22 · open the first message on its own page

[PATCH net v3 1/1] net: tcp: Permit user set TCP_MAXSEG to default value

From: <hidden>
Date: 2017-03-21 01:29:04

From: Gao Feng <redacted>

When user_mss is zero, it means use the default value. But the current
codes don't permit user set TCP_MAXSEG to the default value.
It would return the -EINVAL when val is zero.

Signed-off-by: Gao Feng <redacted>
---
 v3: Correct the logic error, per Neal
 v2: Make codes more clearer, per Eric
 v1: initial version

 net/ipv4/tcp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index 1e319a5..4f7f163 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -2470,7 +2470,7 @@ static int do_tcp_setsockopt(struct sock *sk, int level,
 		/* Values greater than interface MTU won't take effect. However
 		 * at the point when this call is done we typically don't yet
 		 * know which interface is going to be used */
-		if (val < TCP_MIN_MSS || val > MAX_TCP_WINDOW) {
+		if (val && (val < TCP_MIN_MSS || val > MAX_TCP_WINDOW)) {
 			err = -EINVAL;
 			break;
 		}
-- 
1.9.1

Re: [PATCH net v3 1/1] net: tcp: Permit user set TCP_MAXSEG to default value

From: David Miller <davem@davemloft.net>
Date: 2017-03-22 18:48:15

From: fgao@ikuai8.com
Date: Tue, 21 Mar 2017 09:28:03 +0800
From: Gao Feng <redacted>

When user_mss is zero, it means use the default value. But the current
codes don't permit user set TCP_MAXSEG to the default value.
It would return the -EINVAL when val is zero.

Signed-off-by: Gao Feng <redacted>
---
 v3: Correct the logic error, per Neal
 v2: Make codes more clearer, per Eric
 v1: initial version
Applied to net-next, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help