[PATCH] tcp_westwood: fix tcp_westwood_info() style mistakes

Subsystems: networking [general], networking [tcp], the rest

STALE3428d

3 messages, 3 authors, 2017-03-17 · open the first message on its own page

[PATCH] tcp_westwood: fix tcp_westwood_info() style mistakes

From: Chun Long <hidden>
Date: 2017-03-14 07:19:55

From: chun Long <redacted>

replace comma to semi colons in tcp_westwood_info().

---
 net/ipv4/tcp_westwood.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/tcp_westwood.c b/net/ipv4/tcp_westwood.c
index fed66dc..9775453 100644
--- a/net/ipv4/tcp_westwood.c
+++ b/net/ipv4/tcp_westwood.c
@@ -265,8 +265,8 @@ static size_t tcp_westwood_info(struct sock *sk, u32 ext, int *attr,
 	if (ext & (1 << (INET_DIAG_VEGASINFO - 1))) {
 		info->vegas.tcpv_enabled = 1;
 		info->vegas.tcpv_rttcnt	= 0;
-		info->vegas.tcpv_rtt	= jiffies_to_usecs(ca->rtt),
-		info->vegas.tcpv_minrtt	= jiffies_to_usecs(ca->rtt_min),
+		info->vegas.tcpv_rtt	= jiffies_to_usecs(ca->rtt);
+		info->vegas.tcpv_minrtt	= jiffies_to_usecs(ca->rtt_min);
 
 		*attr = INET_DIAG_VEGASINFO;
 		return sizeof(struct tcpvegas_info);
-- 
1.8.3.1

Re: [PATCH] tcp_westwood: fix tcp_westwood_info() style mistakes

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2017-03-14 16:29:43

On Tue, 14 Mar 2017 15:26:24 +0800
Chun Long [off-list ref] wrote:
quoted hunk
From: chun Long <redacted>

replace comma to semi colons in tcp_westwood_info().

---
 net/ipv4/tcp_westwood.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/tcp_westwood.c b/net/ipv4/tcp_westwood.c
index fed66dc..9775453 100644
--- a/net/ipv4/tcp_westwood.c
+++ b/net/ipv4/tcp_westwood.c
@@ -265,8 +265,8 @@ static size_t tcp_westwood_info(struct sock *sk, u32 ext, int *attr,
 	if (ext & (1 << (INET_DIAG_VEGASINFO - 1))) {
 		info->vegas.tcpv_enabled = 1;
 		info->vegas.tcpv_rttcnt	= 0;
-		info->vegas.tcpv_rtt	= jiffies_to_usecs(ca->rtt),
-		info->vegas.tcpv_minrtt	= jiffies_to_usecs(ca->rtt_min),
+		info->vegas.tcpv_rtt	= jiffies_to_usecs(ca->rtt);
+		info->vegas.tcpv_minrtt	= jiffies_to_usecs(ca->rtt_min);
 
 		*attr = INET_DIAG_VEGASINFO;
 		return sizeof(struct tcpvegas_info);
Look fine.

Acked-by: Stephen Hemminger <stephen@networkplumber.org>

Re: [PATCH] tcp_westwood: fix tcp_westwood_info() style mistakes

From: David Miller <davem@davemloft.net>
Date: 2017-03-17 03:24:54

From: Chun Long <redacted>
Date: Tue, 14 Mar 2017 15:26:24 +0800
From: chun Long <redacted>

replace comma to semi colons in tcp_westwood_info().
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help