# \[PATCHv2 2/4\] rds: ib: remove redundant ib\_dealloc\_fmr

- From: Zhu Yanjun \<hidden\>
- Date: 2017-03-12 08:07:56 
- List: netdev
- Page: https://ratatoskr.run/netdev/2017/03/11047056
- Thread: https://ratatoskr.run/linux-rdma/2017/03/11047056/t.md

```text
The function ib_dealloc_fmr will never be called. As such, it should
be removed.

Cc: Joe Jin <redacted>
Cc: Junxiao Bi <redacted>
Reviewed-by: Yuval Shaia <redacted>
Reviewed-by: Johannes Thumshirn <redacted>
Acked-by: Santosh Shilimkar <redacted>
Signed-off-by: Zhu Yanjun <redacted>
---
Change from v1 to v2:
  Add the reviewer and acker.
  Remove ibmr NULL test.

 net/rds/ib_fmr.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/net/rds/ib_fmr.c b/net/rds/ib_fmr.c
index 4fe8f4f..249ae1c 100644
--- a/net/rds/ib_fmr.c
+++ b/net/rds/ib_fmr.c
@@ -78,12 +78,9 @@ struct rds_ib_mr *rds_ib_alloc_fmr(struct rds_ib_device *rds_ibdev, int npages)
 	return ibmr;
 
 out_no_cigar:
-	if (ibmr) {
-		if (fmr->fmr)
-			ib_dealloc_fmr(fmr->fmr);
-		kfree(ibmr);
-	}
+	kfree(ibmr);
 	atomic_dec(&pool->item_count);
+
 	return ERR_PTR(err);
 }
 
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
```