[PATCH] wireless: ipw2200: remove redundant check of rc < 0

Subsystems: intel pro/wireless 2100, 2200bg, 2915abg network connection support, the rest

STALE3459d

2 messages, 2 authors, 2017-03-20 · open the first message on its own page

[PATCH] wireless: ipw2200: remove redundant check of rc < 0

From: Colin King <hidden>
Date: 2017-02-28 00:17:07

From: Colin Ian King <redacted>

The check for rc < 0 is always false so the check is redundant
and can be removed.

Detected with CoverityScan, CID#101143 ("Logically dead code")

Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/wireless/intel/ipw2x00/ipw2200.c | 3 ---
 1 file changed, 3 deletions(-)
diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2200.c b/drivers/net/wireless/intel/ipw2x00/ipw2200.c
index 5ef3c5c..bbc579b 100644
--- a/drivers/net/wireless/intel/ipw2x00/ipw2200.c
+++ b/drivers/net/wireless/intel/ipw2x00/ipw2200.c
@@ -3539,9 +3539,6 @@ static int ipw_load(struct ipw_priv *priv)
 	fw_img = &fw->data[le32_to_cpu(fw->boot_size) +
 			   le32_to_cpu(fw->ucode_size)];
 
-	if (rc < 0)
-		goto error;
-
 	if (!priv->rxq)
 		priv->rxq = ipw_rx_queue_alloc(priv);
 	else
-- 
2.10.2

Re: ipw2200: remove redundant check of rc < 0

From: Kalle Valo <hidden>
Date: 2017-03-20 17:16:44

Colin Ian King [off-list ref] wrote:
From: Colin Ian King <redacted>

The check for rc < 0 is always false so the check is redundant
and can be removed.

Detected with CoverityScan, CID#101143 ("Logically dead code")

Signed-off-by: Colin Ian King <redacted>
Patch applied to wireless-drivers-next.git, thanks.

889cdff72b85 ipw2200: remove redundant check of rc < 0

-- 
https://patchwork.kernel.org/patch/9594495/

Documentation about submitting wireless patches and checking status
from patchwork:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help