[PATCH] iproute2: tc: introduce build dependency on libnetlink

Subsystems: the rest

STALE3484d

2 messages, 2 authors, 2017-02-24 · open the first message on its own page

[PATCH] iproute2: tc: introduce build dependency on libnetlink

From: Jiri Kosina <jikos@kernel.org>
Date: 2017-02-24 18:43:46

From: Jiri Kosina <redacted>

Rebuilding libnetlink doesn't trigger rebuild of tc, which is wrong 
(especially so for builds where libnetlink.a gets statically linked into 
tc). Fix that by introducing an explicit dependency.

Signed-off-by: Jiri Kosina <redacted>
---
 tc/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tc/Makefile b/tc/Makefile
index 6dd984f0..3f7fc939 100644
--- a/tc/Makefile
+++ b/tc/Makefile
@@ -127,7 +127,7 @@ MODDESTDIR := $(DESTDIR)$(LIBDIR)/tc
 
 all: tc $(TCSO)
 
-tc: $(TCOBJ) libtc.a
+tc: $(TCOBJ) $(LIBNETLINK) libtc.a
 	$(QUIET_LINK)$(CC) $^ $(LDFLAGS) $(LDLIBS) -o $@
 
 libtc.a: $(TCLIB)
-- 
Jiri Kosina
SUSE Labs

Re: [PATCH] iproute2: tc: introduce build dependency on libnetlink

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2017-02-24 23:13:12

On Fri, 24 Feb 2017 18:28:54 +0100 (CET)
Jiri Kosina [off-list ref] wrote:
From: Jiri Kosina <redacted>

Rebuilding libnetlink doesn't trigger rebuild of tc, which is wrong 
(especially so for builds where libnetlink.a gets statically linked into 
tc). Fix that by introducing an explicit dependency.

Signed-off-by: Jiri Kosina <redacted>
Makes sense, Applied
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help