[PATCH] net: ena: remove superfluous check in ena_remove()

Subsystems: amazon ethernet drivers, networking drivers, the rest

STALE3473d

2 messages, 2 authors, 2017-02-20 · open the first message on its own page

[PATCH] net: ena: remove superfluous check in ena_remove()

From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Date: 2017-02-18 11:20:22

The check in ena_remove() for the pci driver data not being NULL is not
needed, since it is always set in the probe() function. Remove the
superfluous check.

Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
---
 drivers/net/ethernet/amazon/ena/ena_netdev.c | 6 ------
 1 file changed, 6 deletions(-)
diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
index d8c920b..35f1943 100644
--- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
@@ -3163,12 +3163,6 @@ static void ena_remove(struct pci_dev *pdev)
 	struct ena_com_dev *ena_dev;
 	struct net_device *netdev;
 
-	if (!adapter)
-		/* This device didn't load properly and it's resources
-		 * already released, nothing to do
-		 */
-		return;
-
 	ena_dev = adapter->ena_dev;
 	netdev = adapter->netdev;
 
-- 
2.7.4

Re: [PATCH] net: ena: remove superfluous check in ena_remove()

From: David Miller <davem@davemloft.net>
Date: 2017-02-20 15:24:41

From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Date: Sat, 18 Feb 2017 12:19:41 +0100
The check in ena_remove() for the pci driver data not being NULL is not
needed, since it is always set in the probe() function. Remove the
superfluous check.

Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help