[patch net-next] sched: Fix accidental removal of errout goto

Subsystems: networking [general], tc subsystem, the rest

STALE3495d

2 messages, 2 authors, 2017-02-14 · open the first message on its own page

[patch net-next] sched: Fix accidental removal of errout goto

From: Jiri Pirko <jiri@resnulli.us>
Date: 2017-02-14 15:27:16

From: Jiri Pirko <redacted>

Bring back the goto that was removed by accident.

Reported-by: Colin Ian King <redacted>
Fixes: 40c81b25b16c ("sched: check negative err value to safe one level of indent")
Signed-off-by: Jiri Pirko <redacted>
---
 net/sched/cls_api.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
index abe1fe1..732f7ca 100644
--- a/net/sched/cls_api.c
+++ b/net/sched/cls_api.c
@@ -389,6 +389,7 @@ static int tc_ctl_tfilter(struct sk_buff *skb, struct nlmsghdr *n)
 				       RTM_DELTFILTER, false);
 			if (tcf_proto_destroy(tp, false))
 				RCU_INIT_POINTER(*back, next);
+			goto errout;
 		case RTM_GETTFILTER:
 			err = tfilter_notify(net, skb, n, tp, fh,
 					     RTM_NEWTFILTER, true);
-- 
2.7.4

Re: [patch net-next] sched: Fix accidental removal of errout goto

From: David Miller <davem@davemloft.net>
Date: 2017-02-14 16:44:51

From: Jiri Pirko <jiri@resnulli.us>
Date: Tue, 14 Feb 2017 16:27:13 +0100
From: Jiri Pirko <redacted>

Bring back the goto that was removed by accident.

Reported-by: Colin Ian King <redacted>
Fixes: 40c81b25b16c ("sched: check negative err value to safe one level of indent")
Signed-off-by: Jiri Pirko <redacted>
Applied, thanks Jiri.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help