R: Re: [PATCH net] lwtunnel: valid encap attr check should return 0 when lwtunnel is disabled

From: pupilla@libero.it <hidden>
Date: 2017-02-09 08:49:24

David Miller wrote:
Data: 8-feb-2017 18.55
A: [off-list ref]
Cc: <redacted>, <redacted>
Ogg: Re: [PATCH net] lwtunnel: valid encap attr check should return 0 when 
lwtunnel is disabled
From: David Ahern <redacted>
Date: Wed,  8 Feb 2017 09:29:00 -0800
quoted
An error was reported upgrading to 4.9.8:
    root@Typhoon:~# ip route add default table 210 nexthop dev eth0 via 
10.68.64.1
quoted
    weight 1 nexthop dev eth0 via 10.68.64.2 weight 1
    RTNETLINK answers: Operation not supported

The problem occurs when CONFIG_LWTUNNEL is not enabled and a multipath
route is submitted.

The point of lwtunnel_valid_encap_type_attr is catch modules that
need to be loaded before any references are taken with rntl held. With
CONFIG_LWTUNNEL disabled, there will be no modules to load so the
lwtunnel_valid_encap_type_attr stub should just return 0.

Fixes: 9ed59592e3e3 ("lwtunnel: fix autoload of lwt modules")
Reported-by: pupilla@libero.it
Signed-off-by: David Ahern <redacted>
Applied and queued up for -stable, thanks for fixing this so quickly David.
Thanks everybody. I have applied the patch to linux-4.9.8 and all is fine.

Thanks again.

Marco
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help