# \[PATCH iproute2/net-next repost\] tc: flower: use correct type when calling flower\_icmp\_attr\_type - From: Simon Horman \ - Date: 2017-02-08 12:04:19 - List: netdev - Page: https://ratatoskr.run/netdev/2017/02/11044271 - Thread: https://ratatoskr.run/netdev/2017/02/11044271/t.md ```text Use enum flower_icmp_field rather than bool as type of third parameter when calling flower_icmp_attr_type. Fixes: eb3b5696f163 ("tc: flower: support matching on ICMP type and code") Signed-off-by: Simon Horman --- * Reposted after breaking out of a larger patch-set * This should not have a run-time affect assuming both false and FLOWER_ICMP_FIELD_TYPE - the first value of enum flower_icmp_field - are zero. --- tc/f_flower.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tc/f_flower.c b/tc/f_flower.c index 403100c92af0..c9d56211b040 100644 --- a/tc/f_flower.c +++ b/tc/f_flower.c @@ -1061,10 +1061,12 @@ static int flower_print_opt(struct filter_util *qu, FILE *f, if (nl_type >= 0) flower_print_port(f, "src_port", tb[nl_type]); - nl_type = flower_icmp_attr_type(eth_type, ip_proto, false); + nl_type = flower_icmp_attr_type(eth_type, ip_proto, + FLOWER_ICMP_FIELD_TYPE); if (nl_type >= 0) flower_print_icmp(f, "icmp_type", tb[nl_type]); - nl_type = flower_icmp_attr_type(eth_type, ip_proto, true); + nl_type = flower_icmp_attr_type(eth_type, ip_proto, + FLOWER_ICMP_FIELD_CODE); if (nl_type >= 0) flower_print_icmp(f, "icmp_code", tb[nl_type]); -- 2.7.0.rc3.207.g0ac5344 ```