RE: [RFC v3 09/11] IB/hfi1: HFI_VNIC RDMA netdev support

Hi,

-----Original Message-----
From: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [mailto:linux-rdma-
owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org] On Behalf Of Vishwanathapura, Niranjana
Sent: Tuesday, February 7, 2017 2:23 PM
To: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org;
dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org; ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org; Niranjana
Vishwanathapura [off-list ref]; Andrzej
Kacprowski [off-list ref]
Subject: [RFC v3 09/11] IB/hfi1: HFI_VNIC RDMA netdev support

Add support to create and free HFI_VNIC rdma netdev devices.
Implement netstack interface functionality including xmit_skb, receive side
NAPI etc. Also implement rdma netdev control functions.

All code in this particular patch belong to netdev VNIC ULP driver.
There is nothing much that appears specific to IB/RDMA that makes drivers/infiniband/hw as better place to be.
It has netdev tx, rx, napi, stats in this patch.
If VNIC is a ULP than most of the VNIC specific code should reside in the ULP directory or drivers/net/ethernet ?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

On Wed, Feb 08, 2017 at 04:06:40AM +0000, Parav Pandit wrote:

Hi,

quoted

-----Original Message-----
From: linux-rdma-owner@vger.kernel.org [mailto:linux-rdma-
owner@vger.kernel.org] On Behalf Of Vishwanathapura, Niranjana
Sent: Tuesday, February 7, 2017 2:23 PM
To: dledford@redhat.com
Cc: linux-rdma@vger.kernel.org; netdev@vger.kernel.org;
dennis.dalessandro@intel.com; ira.weiny@intel.com; Niranjana
Vishwanathapura [off-list ref]; Andrzej
Kacprowski [off-list ref]
Subject: [RFC v3 09/11] IB/hfi1: HFI_VNIC RDMA netdev support

Add support to create and free HFI_VNIC rdma netdev devices.
Implement netstack interface functionality including xmit_skb, receive side
NAPI etc. Also implement rdma netdev control functions.

All code in this particular patch belong to netdev VNIC ULP driver.
There is nothing much that appears specific to IB/RDMA that makes drivers/infiniband/hw as better place to be.
It has netdev tx, rx, napi, stats in this patch.
If VNIC is a ULP than most of the VNIC specific code should reside in the ULP directory or drivers/net/ethernet ?

This patch implements HW specific portion of VNIC netdev. As it turnes out HW 
queue spefific netstack interfacing (like NAPI, xmit_skb, Tx queue throttling 
etc) are specific to HW implementation of the queues. Netstack APIs are 
designed for that. Hence they belong in HW driver here and not in ULP.

The HFI_VNIC ULP, implements control plane operatings by tapping into control 
operations (open, close etc and encapsulation as specified by control plane).

Niranjana