[PATCH net-next] sfc: don't rearm interrupts if busy polling

Subsystems: networking drivers, sfc network driver, the rest

STALE3506d

2 messages, 2 authors, 2017-02-06 · open the first message on its own page

[PATCH net-next] sfc: don't rearm interrupts if busy polling

From: Bert Kenward <hidden>
Date: 2017-02-06 16:51:12

Since commit 364b6055738b ("net: busy-poll: return busypolling status
to drivers"), napi_complete_done() returns a boolean that can be used
by drivers to conditionally rearm interrupts.

Testing with a 7142 shows a small latency improvement of ~100 ns.

Signed-off-by: Bert Kenward <redacted>
Cc: Eric Dumazet <edumazet@google.com>
---
 drivers/net/ethernet/sfc/efx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
index fcd4eeecfef4..c28cd9daf949 100644
--- a/drivers/net/ethernet/sfc/efx.c
+++ b/drivers/net/ethernet/sfc/efx.c
@@ -328,8 +328,8 @@ static int efx_poll(struct napi_struct *napi, int budget)
 		 * since efx_nic_eventq_read_ack() will have no effect if
 		 * interrupts have already been disabled.
 		 */
-		napi_complete_done(napi, spent);
-		efx_nic_eventq_read_ack(channel);
+		if (napi_complete_done(napi, spent))
+			efx_nic_eventq_read_ack(channel);
 	}
 
 	return spent;
-- 
2.7.4

Re: [PATCH net-next] sfc: don't rearm interrupts if busy polling

From: David Miller <davem@davemloft.net>
Date: 2017-02-06 16:59:49

From: Bert Kenward <redacted>
Date: Mon, 6 Feb 2017 16:50:55 +0000
Since commit 364b6055738b ("net: busy-poll: return busypolling status
to drivers"), napi_complete_done() returns a boolean that can be used
by drivers to conditionally rearm interrupts.

Testing with a 7142 shows a small latency improvement of ~100 ns.

Signed-off-by: Bert Kenward <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help