[patch net-next] ethernet: aquantia: fix dma_mapping_error test

Subsystems: aquantia ethernet driver (atlantic), networking drivers, the rest

STALE3492d

2 messages, 2 authors, 2017-02-01 · open the first message on its own page

[patch net-next] ethernet: aquantia: fix dma_mapping_error test

From: Dan Carpenter <hidden>
Date: 2017-02-01 08:52:36

dma_mapping_error() returns 1 if there is an error and 0 if not.

Fixes: 018423e90bee ("net: ethernet: aquantia: Add ring support code")
Signed-off-by: Dan Carpenter <redacted>
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
index 817c145520c8..dea9e9bbb8e7 100644
--- a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
+++ b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
@@ -298,9 +298,10 @@ int aq_ring_rx_fill(struct aq_ring_s *self)
 					buff->page, 0,
 					AQ_CFG_RX_FRAME_MAX, DMA_FROM_DEVICE);
 
-		err = dma_mapping_error(aq_nic_get_dev(self->aq_nic), buff->pa);
-		if (err < 0)
+		if (dma_mapping_error(aq_nic_get_dev(self->aq_nic), buff->pa)) {
+			err = -ENOMEM;
 			goto err_exit;
+		}
 
 		buff = NULL;
 	}

Re: [patch net-next] ethernet: aquantia: fix dma_mapping_error test

From: David Miller <davem@davemloft.net>
Date: 2017-02-01 17:45:50

From: Dan Carpenter <redacted>
Date: Wed, 1 Feb 2017 11:52:15 +0300
dma_mapping_error() returns 1 if there is an error and 0 if not.

Fixes: 018423e90bee ("net: ethernet: aquantia: Add ring support code")
Signed-off-by: Dan Carpenter <redacted>
Applied, thanks Dan.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help