[PATCH/RFC net] ravb: Remove Rx overflow log messages

Subsystems: networking drivers, renesas ethernet avb driver, the rest

2 messages, 2 authors, 2017-01-12 · open the first message on its own page

[PATCH/RFC net] ravb: Remove Rx overflow log messages

From: Simon Horman <hidden>
Date: 2017-01-12 08:42:41

From: Kazuya Mizuguchi <redacted>

Remove Rx overflow log messages as in an environment where logging results
in network traffic logging may cause further overflows.

Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
Signed-off-by: Kazuya Mizuguchi <redacted>
[simon: reworked changelog]
Signed-off-by: Simon Horman <redacted>
---
 drivers/net/ethernet/renesas/ravb_main.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
index 92d7692c840d..5e5ad978eab9 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -926,14 +926,10 @@ static int ravb_poll(struct napi_struct *napi, int budget)
 	/* Receive error message handling */
 	priv->rx_over_errors =  priv->stats[RAVB_BE].rx_over_errors;
 	priv->rx_over_errors += priv->stats[RAVB_NC].rx_over_errors;
-	if (priv->rx_over_errors != ndev->stats.rx_over_errors) {
+	if (priv->rx_over_errors != ndev->stats.rx_over_errors)
 		ndev->stats.rx_over_errors = priv->rx_over_errors;
-		netif_err(priv, rx_err, ndev, "Receive Descriptor Empty\n");
-	}
-	if (priv->rx_fifo_errors != ndev->stats.rx_fifo_errors) {
+	if (priv->rx_fifo_errors != ndev->stats.rx_fifo_errors)
 		ndev->stats.rx_fifo_errors = priv->rx_fifo_errors;
-		netif_err(priv, rx_err, ndev, "Receive FIFO Overflow\n");
-	}
 out:
 	return budget - quota;
 }
-- 
2.7.0.rc3.207.g0ac5344

Re: [PATCH/RFC net] ravb: Remove Rx overflow log messages

From: Sergei Shtylyov <hidden>
Date: 2017-01-12 11:52:07

On 01/12/2017 11:41 AM, Simon Horman wrote:
From: Kazuya Mizuguchi <redacted>

Remove Rx overflow log messages as in an environment where logging results
in network traffic logging may cause further overflows.

Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
Signed-off-by: Kazuya Mizuguchi <redacted>
[simon: reworked changelog]
Signed-off-by: Simon Horman <redacted>
Acked-by: Sergei Shtylyov <redacted>

MBR, Sergei
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help