[PATCH][net-next] net: ethernet: aquantia: remove another redundant err check

Subsystems: aquantia ethernet driver (atlantic), networking drivers, the rest

STALE3495d

2 messages, 2 authors, 2017-01-29 · open the first message on its own page

[PATCH][net-next] net: ethernet: aquantia: remove another redundant err check

From: Colin King <hidden>
Date: 2017-01-27 15:37:40

From: Colin Ian King <redacted>

The check on err < 0 is redundant and can be removed. Detected
by CoverityScan, CID#1398318 ("Logically Dead Code")

Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/ethernet/aquantia/atlantic/aq_ring.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
index b517b26..817c145 100644
--- a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
+++ b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
@@ -304,8 +304,6 @@ int aq_ring_rx_fill(struct aq_ring_s *self)
 
 		buff = NULL;
 	}
-	if (err < 0)
-		goto err_exit;
 
 err_exit:
 	if (err < 0) {
-- 
2.10.2

Re: [PATCH][net-next] net: ethernet: aquantia: remove another redundant err check

From: David Miller <davem@davemloft.net>
Date: 2017-01-29 23:24:31

From: Colin King <redacted>
Date: Fri, 27 Jan 2017 15:00:25 +0000
From: Colin Ian King <redacted>

The check on err < 0 is redundant and can be removed. Detected
by CoverityScan, CID#1398318 ("Logically Dead Code")

Signed-off-by: Colin Ian King <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help