[PATCH][net-next] net: ethernet: aquantia: remove redundant err check

Subsystems: aquantia ethernet driver (atlantic), networking drivers, the rest

STALE3489d

2 messages, 2 authors, 2017-01-29 · open the first message on its own page

[PATCH][net-next] net: ethernet: aquantia: remove redundant err check

From: Colin King <hidden>
Date: 2017-01-27 15:21:59

From: Colin Ian King <redacted>

The check on err < 0 is redundant and can be removed. Detected
by CoverityScan, CID#1398321 ("Logically Dead Code")

Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c b/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c
index afcecdb..da4bc09 100644
--- a/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c
+++ b/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c
@@ -145,8 +145,6 @@ int aq_pci_func_init(struct aq_pci_func_s *self)
 		}
 	}
 
-	if (err < 0)
-		goto err_exit;
 	for (i = 0; i < self->aq_hw_caps.msix_irqs; i++)
 		self->msix_entry[i].entry = i;
 
-- 
2.10.2

Re: [PATCH][net-next] net: ethernet: aquantia: remove redundant err check

From: David Miller <davem@davemloft.net>
Date: 2017-01-29 23:24:25

From: Colin King <redacted>
Date: Fri, 27 Jan 2017 14:43:46 +0000
From: Colin Ian King <redacted>

The check on err < 0 is redundant and can be removed. Detected
by CoverityScan, CID#1398321 ("Logically Dead Code")

Signed-off-by: Colin Ian King <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help