# Re: \[PATCHv2 7/7\] IPVTAP: IP-VLAN based tap driver

- From: David Miller \<davem@davemloft.net\>
- Date: 2017-01-18 21:28:45 
- List: netdev
- Page: https://ratatoskr.run/netdev/2017/01/4915694
- Thread: https://ratatoskr.run/netdev/2017/01/4914646/t.md

```text
From: Sainath Grandhi <redacted>
Date: Tue, 17 Jan 2017 16:03:06 -0800

> +static void ipvtap_count_tx_dropped(struct tap_dev *tap)
> +{
> +	struct ipvl_dev *vlan = (struct ipvl_dev *)container_of(tap, struct ipvtap_dev, tap);
 ...
> +static void ipvtap_count_rx_dropped(struct tap_dev *tap)
> +{
> +	struct ipvl_dev *vlan = (struct ipvl_dev *)container_of(tap, struct ipvtap_dev, tap);
 ...
> +static void ipvtap_update_features(struct tap_dev *tap,
> +				   netdev_features_t features)
> +{
> +	struct ipvl_dev *vlan = (struct ipvl_dev *)container_of(tap, struct ipvtap_dev, tap);

More unnecessary casts, please remove.
```