# Re: \[PATCH net-next\] net: make ndo\_get\_stats64 a void function

- From: David Miller \<hidden\>
- Date: 2017-01-05 18:21:07 
- List: netdev
- Page: https://ratatoskr.run/netdev/2017/01/4905608
- Thread: https://ratatoskr.run/netdev/2017/01/4905569/t.md

```text
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Thu,  5 Jan 2017 09:31:36 -0800

> The network device operation for reading statistics is only called
> in one place, and it ignores the return value. Having a structure
> return value is potentially confusing because some future driver could
> incorrectly assume that the return value was used.
> 
> Fix all drivers with ndo_get_stats64 to have a void function.
> 
> Signed-off-by: Stephen Hemminger <redacted>

You missed at least one new warning, please do a fresh allmodconfig build
and watch the logs.

drivers/net/ethernet/broadcom/bnx2.c: In function ‘bnx2_get_stats64’:
drivers/net/ethernet/broadcom/bnx2.c:6830:10: warning: ‘return’ with a value, in function returning void

Thanks.
_______________________________________________
dev mailing list
dev@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
```
