2 messages, 2 authors, 2017-01-25 · open the first message on its own page
From: Oliver Neukum <oneukum@suse.com>
Date: 2017-01-25 09:34:57
Hi, looking at r8152 I noticed that it uses NAPI. I never considered this for the generic USB networking code as you cannot disable interrupts for USB. Is it still worth it? What are the benefits? Regards Oliver
From: David Miller <davem@davemloft.net>
Date: 2017-01-25 19:32:28
From: Oliver Neukum <oneukum@suse.com> Date: Wed, 25 Jan 2017 10:34:41 +0100
looking at r8152 I noticed that it uses NAPI. I never considered this for the generic USB networking code as you cannot disable interrupts for USB. Is it still worth it? What are the benefits?
I think it's not a good approach for getting GRO. Exactly because of the issue you raise, in that USB drivers cannot stop the URBs from coming in while running their poll method.