[PATCH] stmicro: rename it to dwc to improve future development

Subsystems: networking drivers, the rest

STALE3521d

4 messages, 3 authors, 2017-01-17 · open the first message on its own page

[PATCH] stmicro: rename it to dwc to improve future development

From: Joao Pinto <hidden>
Date: 2017-01-16 13:26:42 

The goal of this patch is to create an oficial Designware Ethernet place
to deploy new drivers based on this family of IPs. stmmac was left
untouched since it is a designware based driver. New ethernet designware
IP based drivers should be placed in this place, improving code organization
and it becomes clear to the kernel user the purpose and scope of each driver.

Signed-off-by: Joao Pinto <redacted>
---
 drivers/net/ethernet/Kconfig                                     | 2 +-
 drivers/net/ethernet/Makefile                                    | 2 +-
 drivers/net/ethernet/{stmicro => dwc}/Kconfig                    | 7 ++++---
 drivers/net/ethernet/dwc/Makefile                                | 5 +++++
 drivers/net/ethernet/{stmicro => dwc}/stmmac/Kconfig             | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/Makefile            | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/altr_tse_pcs.c      | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/altr_tse_pcs.h      | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/chain_mode.c        | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/common.h            | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/descs.h             | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/descs_com.h         | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac-dwc-qos-eth.c | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac-generic.c     | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac-ipq806x.c     | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac-lpc18xx.c     | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac-meson.c       | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac-meson8b.c     | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac-oxnas.c       | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac-rk.c          | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac-socfpga.c     | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac-sti.c         | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac-stm32.c       | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac-sunxi.c       | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac100.h          | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac1000.h         | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac1000_core.c    | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac1000_dma.c     | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac100_core.c     | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac100_dma.c      | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac4.h            | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac4_core.c       | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac4_descs.c      | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac4_descs.h      | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac4_dma.c        | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac4_dma.h        | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac4_lib.c        | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac_dma.h         | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac_lib.c         | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/enh_desc.c          | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/mmc.h               | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/mmc_core.c          | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/norm_desc.c         | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/ring_mode.c         | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/stmmac.h            | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/stmmac_ethtool.c    | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/stmmac_hwtstamp.c   | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/stmmac_main.c       | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/stmmac_mdio.c       | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/stmmac_pci.c        | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/stmmac_pcs.h        | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/stmmac_platform.c   | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/stmmac_platform.h   | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/stmmac_ptp.c        | 0
 drivers/net/ethernet/{stmicro => dwc}/stmmac/stmmac_ptp.h        | 0
 drivers/net/ethernet/stmicro/Makefile                            | 5 -----
 56 files changed, 11 insertions(+), 10 deletions(-)
 rename drivers/net/ethernet/{stmicro => dwc}/Kconfig (68%)
 create mode 100644 drivers/net/ethernet/dwc/Makefile
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/Kconfig (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/Makefile (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/altr_tse_pcs.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/altr_tse_pcs.h (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/chain_mode.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/common.h (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/descs.h (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/descs_com.h (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac-dwc-qos-eth.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac-generic.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac-ipq806x.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac-lpc18xx.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac-meson.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac-meson8b.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac-oxnas.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac-rk.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac-socfpga.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac-sti.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac-stm32.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac-sunxi.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac100.h (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac1000.h (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac1000_core.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac1000_dma.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac100_core.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac100_dma.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac4.h (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac4_core.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac4_descs.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac4_descs.h (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac4_dma.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac4_dma.h (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac4_lib.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac_dma.h (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/dwmac_lib.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/enh_desc.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/mmc.h (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/mmc_core.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/norm_desc.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/ring_mode.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/stmmac.h (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/stmmac_ethtool.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/stmmac_hwtstamp.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/stmmac_main.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/stmmac_mdio.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/stmmac_pci.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/stmmac_pcs.h (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/stmmac_platform.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/stmmac_platform.h (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/stmmac_ptp.c (100%)
 rename drivers/net/ethernet/{stmicro => dwc}/stmmac/stmmac_ptp.h (100%)
 delete mode 100644 drivers/net/ethernet/stmicro/Makefile

diff --git a/drivers/net/ethernet/Kconfig b/drivers/net/ethernet/Kconfig
index afc07d4..33fa603 100644
--- a/drivers/net/ethernet/Kconfig
+++ b/drivers/net/ethernet/Kconfig
@@ -168,7 +168,7 @@ source "drivers/net/ethernet/sis/Kconfig"
 source "drivers/net/ethernet/sfc/Kconfig"
 source "drivers/net/ethernet/sgi/Kconfig"
 source "drivers/net/ethernet/smsc/Kconfig"
-source "drivers/net/ethernet/stmicro/Kconfig"
+source "drivers/net/ethernet/dwc/Kconfig"
 source "drivers/net/ethernet/sun/Kconfig"
 source "drivers/net/ethernet/tehuti/Kconfig"
 source "drivers/net/ethernet/ti/Kconfig"
diff --git a/drivers/net/ethernet/Makefile b/drivers/net/ethernet/Makefile
index e7861a8..fc81d9a 100644
--- a/drivers/net/ethernet/Makefile
+++ b/drivers/net/ethernet/Makefile
@@ -79,7 +79,7 @@ obj-$(CONFIG_SFC) += sfc/
 obj-$(CONFIG_SFC_FALCON) += sfc/falcon/
 obj-$(CONFIG_NET_VENDOR_SGI) += sgi/
 obj-$(CONFIG_NET_VENDOR_SMSC) += smsc/
-obj-$(CONFIG_NET_VENDOR_STMICRO) += stmicro/
+obj-$(CONFIG_NET_VENDOR_STMICRO) += dwc/
 obj-$(CONFIG_NET_VENDOR_SUN) += sun/
 obj-$(CONFIG_NET_VENDOR_TEHUTI) += tehuti/
 obj-$(CONFIG_NET_VENDOR_TI) += ti/
diff --git a/drivers/net/ethernet/stmicro/Kconfig b/drivers/net/ethernet/dwc/Kconfig
similarity index 68%
rename from drivers/net/ethernet/stmicro/Kconfig
rename to drivers/net/ethernet/dwc/Kconfig
index 1c1157d..fe3e630 100644
--- a/drivers/net/ethernet/stmicro/Kconfig
+++ b/drivers/net/ethernet/dwc/Kconfig
@@ -1,5 +1,5 @@
 #
-# STMicroelectronics device configuration
+# Designware based device drivers configuration
 #
 
 config NET_VENDOR_STMICRO
@@ -7,7 +7,8 @@ config NET_VENDOR_STMICRO
 	default y
 	depends on HAS_IOMEM
 	---help---
-	  If you have a network (Ethernet) card belonging to this class, say Y.
+	  If you have a network (Ethernet) card based on Designware
+	  Ethernet 10/100/1G/QoS IPs, say Y.
 
 	  Note that the answer to this question doesn't directly affect the
 	  kernel: saying N will just cause the configurator to skip all
@@ -16,6 +17,6 @@ config NET_VENDOR_STMICRO
 
 if NET_VENDOR_STMICRO
 
-source "drivers/net/ethernet/stmicro/stmmac/Kconfig"
+source "drivers/net/ethernet/dwc/stmmac/Kconfig"
 
 endif # NET_VENDOR_STMICRO
diff --git a/drivers/net/ethernet/dwc/Makefile b/drivers/net/ethernet/dwc/Makefile
new file mode 100644
index 0000000..788b1ba
--- /dev/null
+++ b/drivers/net/ethernet/dwc/Makefile
@@ -0,0 +1,5 @@
+#
+# Makefile for the Designware based device drivers.
+#
+
+obj-$(CONFIG_STMMAC_ETH) += stmmac/
diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/ethernet/dwc/stmmac/Kconfig
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/Kconfig
rename to drivers/net/ethernet/dwc/stmmac/Kconfig
diff --git a/drivers/net/ethernet/stmicro/stmmac/Makefile b/drivers/net/ethernet/dwc/stmmac/Makefile
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/Makefile
rename to drivers/net/ethernet/dwc/stmmac/Makefile
diff --git a/drivers/net/ethernet/stmicro/stmmac/altr_tse_pcs.c b/drivers/net/ethernet/dwc/stmmac/altr_tse_pcs.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/altr_tse_pcs.c
rename to drivers/net/ethernet/dwc/stmmac/altr_tse_pcs.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/altr_tse_pcs.h b/drivers/net/ethernet/dwc/stmmac/altr_tse_pcs.h
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/altr_tse_pcs.h
rename to drivers/net/ethernet/dwc/stmmac/altr_tse_pcs.h
diff --git a/drivers/net/ethernet/stmicro/stmmac/chain_mode.c b/drivers/net/ethernet/dwc/stmmac/chain_mode.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/chain_mode.c
rename to drivers/net/ethernet/dwc/stmmac/chain_mode.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/common.h b/drivers/net/ethernet/dwc/stmmac/common.h
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/common.h
rename to drivers/net/ethernet/dwc/stmmac/common.h
diff --git a/drivers/net/ethernet/stmicro/stmmac/descs.h b/drivers/net/ethernet/dwc/stmmac/descs.h
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/descs.h
rename to drivers/net/ethernet/dwc/stmmac/descs.h
diff --git a/drivers/net/ethernet/stmicro/stmmac/descs_com.h b/drivers/net/ethernet/dwc/stmmac/descs_com.h
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/descs_com.h
rename to drivers/net/ethernet/dwc/stmmac/descs_com.h
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c b/drivers/net/ethernet/dwc/stmmac/dwmac-dwc-qos-eth.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c
rename to drivers/net/ethernet/dwc/stmmac/dwmac-dwc-qos-eth.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c b/drivers/net/ethernet/dwc/stmmac/dwmac-generic.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c
rename to drivers/net/ethernet/dwc/stmmac/dwmac-generic.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c b/drivers/net/ethernet/dwc/stmmac/dwmac-ipq806x.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c
rename to drivers/net/ethernet/dwc/stmmac/dwmac-ipq806x.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c b/drivers/net/ethernet/dwc/stmmac/dwmac-lpc18xx.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c
rename to drivers/net/ethernet/dwc/stmmac/dwmac-lpc18xx.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson.c b/drivers/net/ethernet/dwc/stmmac/dwmac-meson.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/dwmac-meson.c
rename to drivers/net/ethernet/dwc/stmmac/dwmac-meson.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c b/drivers/net/ethernet/dwc/stmmac/dwmac-meson8b.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c
rename to drivers/net/ethernet/dwc/stmmac/dwmac-meson8b.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-oxnas.c b/drivers/net/ethernet/dwc/stmmac/dwmac-oxnas.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/dwmac-oxnas.c
rename to drivers/net/ethernet/dwc/stmmac/dwmac-oxnas.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c b/drivers/net/ethernet/dwc/stmmac/dwmac-rk.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
rename to drivers/net/ethernet/dwc/stmmac/dwmac-rk.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c b/drivers/net/ethernet/dwc/stmmac/dwmac-socfpga.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
rename to drivers/net/ethernet/dwc/stmmac/dwmac-socfpga.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c b/drivers/net/ethernet/dwc/stmmac/dwmac-sti.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c
rename to drivers/net/ethernet/dwc/stmmac/dwmac-sti.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c b/drivers/net/ethernet/dwc/stmmac/dwmac-stm32.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c
rename to drivers/net/ethernet/dwc/stmmac/dwmac-stm32.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c b/drivers/net/ethernet/dwc/stmmac/dwmac-sunxi.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c
rename to drivers/net/ethernet/dwc/stmmac/dwmac-sunxi.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac100.h b/drivers/net/ethernet/dwc/stmmac/dwmac100.h
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/dwmac100.h
rename to drivers/net/ethernet/dwc/stmmac/dwmac100.h
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac1000.h b/drivers/net/ethernet/dwc/stmmac/dwmac1000.h
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/dwmac1000.h
rename to drivers/net/ethernet/dwc/stmmac/dwmac1000.h
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c b/drivers/net/ethernet/dwc/stmmac/dwmac1000_core.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c
rename to drivers/net/ethernet/dwc/stmmac/dwmac1000_core.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac1000_dma.c b/drivers/net/ethernet/dwc/stmmac/dwmac1000_dma.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/dwmac1000_dma.c
rename to drivers/net/ethernet/dwc/stmmac/dwmac1000_dma.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac100_core.c b/drivers/net/ethernet/dwc/stmmac/dwmac100_core.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/dwmac100_core.c
rename to drivers/net/ethernet/dwc/stmmac/dwmac100_core.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac100_dma.c b/drivers/net/ethernet/dwc/stmmac/dwmac100_dma.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/dwmac100_dma.c
rename to drivers/net/ethernet/dwc/stmmac/dwmac100_dma.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4.h b/drivers/net/ethernet/dwc/stmmac/dwmac4.h
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/dwmac4.h
rename to drivers/net/ethernet/dwc/stmmac/dwmac4.h
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c b/drivers/net/ethernet/dwc/stmmac/dwmac4_core.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
rename to drivers/net/ethernet/dwc/stmmac/dwmac4_core.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c b/drivers/net/ethernet/dwc/stmmac/dwmac4_descs.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c
rename to drivers/net/ethernet/dwc/stmmac/dwmac4_descs.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.h b/drivers/net/ethernet/dwc/stmmac/dwmac4_descs.h
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.h
rename to drivers/net/ethernet/dwc/stmmac/dwmac4_descs.h
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.c b/drivers/net/ethernet/dwc/stmmac/dwmac4_dma.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.c
rename to drivers/net/ethernet/dwc/stmmac/dwmac4_dma.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h b/drivers/net/ethernet/dwc/stmmac/dwmac4_dma.h
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h
rename to drivers/net/ethernet/dwc/stmmac/dwmac4_dma.h
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c b/drivers/net/ethernet/dwc/stmmac/dwmac4_lib.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c
rename to drivers/net/ethernet/dwc/stmmac/dwmac4_lib.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac_dma.h b/drivers/net/ethernet/dwc/stmmac/dwmac_dma.h
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/dwmac_dma.h
rename to drivers/net/ethernet/dwc/stmmac/dwmac_dma.h
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c b/drivers/net/ethernet/dwc/stmmac/dwmac_lib.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c
rename to drivers/net/ethernet/dwc/stmmac/dwmac_lib.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/enh_desc.c b/drivers/net/ethernet/dwc/stmmac/enh_desc.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/enh_desc.c
rename to drivers/net/ethernet/dwc/stmmac/enh_desc.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/mmc.h b/drivers/net/ethernet/dwc/stmmac/mmc.h
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/mmc.h
rename to drivers/net/ethernet/dwc/stmmac/mmc.h
diff --git a/drivers/net/ethernet/stmicro/stmmac/mmc_core.c b/drivers/net/ethernet/dwc/stmmac/mmc_core.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/mmc_core.c
rename to drivers/net/ethernet/dwc/stmmac/mmc_core.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/norm_desc.c b/drivers/net/ethernet/dwc/stmmac/norm_desc.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/norm_desc.c
rename to drivers/net/ethernet/dwc/stmmac/norm_desc.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/ring_mode.c b/drivers/net/ethernet/dwc/stmmac/ring_mode.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/ring_mode.c
rename to drivers/net/ethernet/dwc/stmmac/ring_mode.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac.h b/drivers/net/ethernet/dwc/stmmac/stmmac.h
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/stmmac.h
rename to drivers/net/ethernet/dwc/stmmac/stmmac.h
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c b/drivers/net/ethernet/dwc/stmmac/stmmac_ethtool.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
rename to drivers/net/ethernet/dwc/stmmac/stmmac_ethtool.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c b/drivers/net/ethernet/dwc/stmmac/stmmac_hwtstamp.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c
rename to drivers/net/ethernet/dwc/stmmac/stmmac_hwtstamp.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/dwc/stmmac/stmmac_main.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
rename to drivers/net/ethernet/dwc/stmmac/stmmac_main.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/dwc/stmmac/stmmac_mdio.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
rename to drivers/net/ethernet/dwc/stmmac/stmmac_mdio.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c b/drivers/net/ethernet/dwc/stmmac/stmmac_pci.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c
rename to drivers/net/ethernet/dwc/stmmac/stmmac_pci.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_pcs.h b/drivers/net/ethernet/dwc/stmmac/stmmac_pcs.h
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/stmmac_pcs.h
rename to drivers/net/ethernet/dwc/stmmac/stmmac_pcs.h
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/dwc/stmmac/stmmac_platform.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
rename to drivers/net/ethernet/dwc/stmmac/stmmac_platform.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.h b/drivers/net/ethernet/dwc/stmmac/stmmac_platform.h
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/stmmac_platform.h
rename to drivers/net/ethernet/dwc/stmmac/stmmac_platform.h
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c b/drivers/net/ethernet/dwc/stmmac/stmmac_ptp.c
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
rename to drivers/net/ethernet/dwc/stmmac/stmmac_ptp.c
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.h b/drivers/net/ethernet/dwc/stmmac/stmmac_ptp.h
similarity index 100%
rename from drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.h
rename to drivers/net/ethernet/dwc/stmmac/stmmac_ptp.h
diff --git a/drivers/net/ethernet/stmicro/Makefile b/drivers/net/ethernet/stmicro/Makefile
deleted file mode 100644
index 9b3bfdd..0000000
--- a/drivers/net/ethernet/stmicro/Makefile
+++ /dev/null
@@ -1,5 +0,0 @@
-#
-# Makefile for the STMicroelectronics device drivers.
-#
-
-obj-$(CONFIG_STMMAC_ETH) += stmmac/
-- 
2.9.3

Re: [PATCH] stmicro: rename it to dwc to improve future development

From: David Miller <davem@davemloft.net>
Date: 2017-01-16 18:58:52 

From: Joao Pinto <redacted>
Date: Mon, 16 Jan 2017 13:26:31 +0000

The goal of this patch is to create an oficial Designware Ethernet place
to deploy new drivers based on this family of IPs. stmmac was left
untouched since it is a designware based driver. New ethernet designware
IP based drivers should be placed in this place, improving code organization
and it becomes clear to the kernel user the purpose and scope of each driver.

Signed-off-by: Joao Pinto <redacted>
Sorry, I am not applying this.

This would mean that every single -stable backport of a fix to this
driver would require fixing up the directory and/or file name of every
single change without any exception.

This is an unreasonable burdon to put upon me, and every single person
who has to backport bug fixes into older releases of the kernel.

Please stop submitting this rename change.  It is fine to leave the
driver with the stmmac name, and there is zero user benefit to the
rename and only negatives for people who have to work on backports.

I saw no agreement reached between yourself and anyone who voiced
opposition to this driver rename.  Therefore it was entirely
inappropriate for you to resubmit this change again.

I heard very clearly your argument that you would help with the problem
with the backports, but that is a completely empty gesture.  Here's why.

You cannot help with the problem, nor can any other developer working
on this driver.  People all over the world are going to want to
backport this patch or that, and I myself work in my own little
routine and can't depend on having to have a back and forth with you
over and over again for every single fix to this driver I decide is
reasonable for a -stable backport.

Re: [PATCH] stmicro: rename it to dwc to improve future development

From: kbuild test robot <hidden>
Date: 2017-01-17 03:14:19 

Hi Joao,

[auto build test WARNING on net-next/master]
[also build test WARNING on next-20170116]
[cannot apply to v4.10-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Joao-Pinto/stmicro-rename-it-to-dwc-to-improve-future-development/20170116-214440
config: m32r-allyesconfig (attached as .config)
compiler: m32r-linux-gcc (GCC) 6.2.0
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=m32r 

All warnings (new ones prefixed by >>):

   In file included from include/linux/printk.h:6:0,
                    from include/linux/kernel.h:13,
                    from include/asm-generic/bug.h:13,
                    from arch/m32r/include/asm/bug.h:3,
                    from include/linux/bug.h:4,
                    from include/linux/mmdebug.h:4,
                    from include/linux/gfp.h:4,
                    from include/linux/slab.h:14,
                    from drivers/net/ethernet/dwc/stmmac/dwmac1000_core.c:30:
   drivers/net/ethernet/dwc/stmmac/dwmac1000_core.c: In function 'dwmac1000_dump_regs':
   include/linux/kern_levels.h:4:18: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'long unsigned int' [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^
   include/linux/kern_levels.h:13:19: note: in expansion of macro 'KERN_SOH'
    #define KERN_INFO KERN_SOH "6" /* informational */
                      ^~~~~~~~
   include/linux/printk.h:299:9: note: in expansion of macro 'KERN_INFO'
     printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
            ^~~~~~~~~
quoted
drivers/net/ethernet/dwc/stmmac/dwmac1000_core.c:107:3: note: in expansion of macro 'pr_info'
      pr_info("\tReg No. %d (offset 0x%x): 0x%08x\n", i,
      ^~~~~~~
--
   In file included from include/linux/printk.h:6:0,
                    from include/linux/kernel.h:13,
                    from include/linux/list.h:8,
                    from include/linux/preempt.h:10,
                    from include/linux/spinlock.h:50,
                    from include/linux/phy.h:20,
                    from drivers/net/ethernet/dwc/stmmac/dwmac1000.h:25,
                    from drivers/net/ethernet/dwc/stmmac/dwmac1000_dma.c:30:
   drivers/net/ethernet/dwc/stmmac/dwmac1000_dma.c: In function 'dwmac1000_dump_dma_regs':
   include/linux/kern_levels.h:4:18: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'long unsigned int' [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^
   include/linux/kern_levels.h:10:18: note: in expansion of macro 'KERN_SOH'
    #define KERN_ERR KERN_SOH "3" /* error conditions */
                     ^~~~~~~~
   include/linux/printk.h:292:9: note: in expansion of macro 'KERN_ERR'
     printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
            ^~~~~~~~
quoted
drivers/net/ethernet/dwc/stmmac/dwmac1000_dma.c:215:4: note: in expansion of macro 'pr_err'
       pr_err("\t Reg No. %d (offset 0x%x): 0x%08x\n", i,
       ^~~~~~
--
   In file included from include/linux/printk.h:6:0,
                    from include/linux/kernel.h:13,
                    from include/linux/list.h:8,
                    from include/linux/preempt.h:10,
                    from include/linux/spinlock.h:50,
                    from include/linux/phy.h:20,
                    from drivers/net/ethernet/dwc/stmmac/dwmac100.h:28,
                    from drivers/net/ethernet/dwc/stmmac/dwmac100_core.c:33:
   drivers/net/ethernet/dwc/stmmac/dwmac100_core.c: In function 'dwmac100_dump_mac_regs':
   include/linux/kern_levels.h:4:18: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'long unsigned int' [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^
   include/linux/kern_levels.h:13:19: note: in expansion of macro 'KERN_SOH'
    #define KERN_INFO KERN_SOH "6" /* informational */
                      ^~~~~~~~
   include/linux/printk.h:299:9: note: in expansion of macro 'KERN_INFO'
     printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
            ^~~~~~~~~
quoted
drivers/net/ethernet/dwc/stmmac/dwmac100_core.c:53:2: note: in expansion of macro 'pr_info'
     pr_info("\tcontrol reg (offset 0x%x): 0x%08x\n", MAC_CONTROL,
     ^~~~~~~
   include/linux/kern_levels.h:4:18: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'long unsigned int' [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^
   include/linux/kern_levels.h:13:19: note: in expansion of macro 'KERN_SOH'
    #define KERN_INFO KERN_SOH "6" /* informational */
                      ^~~~~~~~
   include/linux/printk.h:299:9: note: in expansion of macro 'KERN_INFO'
     printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
            ^~~~~~~~~
   drivers/net/ethernet/dwc/stmmac/dwmac100_core.c:55:2: note: in expansion of macro 'pr_info'
     pr_info("\taddr HI (offset 0x%x): 0x%08x\n ", MAC_ADDR_HIGH,
     ^~~~~~~
   include/linux/kern_levels.h:4:18: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'long unsigned int' [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^
   include/linux/kern_levels.h:13:19: note: in expansion of macro 'KERN_SOH'
    #define KERN_INFO KERN_SOH "6" /* informational */
                      ^~~~~~~~
   include/linux/printk.h:299:9: note: in expansion of macro 'KERN_INFO'
     printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
            ^~~~~~~~~
   drivers/net/ethernet/dwc/stmmac/dwmac100_core.c:57:2: note: in expansion of macro 'pr_info'
     pr_info("\taddr LO (offset 0x%x): 0x%08x\n", MAC_ADDR_LOW,
     ^~~~~~~
   include/linux/kern_levels.h:4:18: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'long unsigned int' [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^
   include/linux/kern_levels.h:13:19: note: in expansion of macro 'KERN_SOH'
    #define KERN_INFO KERN_SOH "6" /* informational */
                      ^~~~~~~~
   include/linux/printk.h:299:9: note: in expansion of macro 'KERN_INFO'
     printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
            ^~~~~~~~~
   drivers/net/ethernet/dwc/stmmac/dwmac100_core.c:59:2: note: in expansion of macro 'pr_info'
     pr_info("\tmulticast hash HI (offset 0x%x): 0x%08x\n",
     ^~~~~~~
   include/linux/kern_levels.h:4:18: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'long unsigned int' [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^
   include/linux/kern_levels.h:13:19: note: in expansion of macro 'KERN_SOH'
    #define KERN_INFO KERN_SOH "6" /* informational */
                      ^~~~~~~~
   include/linux/printk.h:299:9: note: in expansion of macro 'KERN_INFO'
     printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
            ^~~~~~~~~
   drivers/net/ethernet/dwc/stmmac/dwmac100_core.c:61:2: note: in expansion of macro 'pr_info'
     pr_info("\tmulticast hash LO (offset 0x%x): 0x%08x\n",
     ^~~~~~~
   include/linux/kern_levels.h:4:18: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'long unsigned int' [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^
   include/linux/kern_levels.h:13:19: note: in expansion of macro 'KERN_SOH'
    #define KERN_INFO KERN_SOH "6" /* informational */
                      ^~~~~~~~
   include/linux/printk.h:299:9: note: in expansion of macro 'KERN_INFO'
     printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
            ^~~~~~~~~
   drivers/net/ethernet/dwc/stmmac/dwmac100_core.c:63:2: note: in expansion of macro 'pr_info'
     pr_info("\tflow control (offset 0x%x): 0x%08x\n",
     ^~~~~~~
   include/linux/kern_levels.h:4:18: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'long unsigned int' [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^
   include/linux/kern_levels.h:13:19: note: in expansion of macro 'KERN_SOH'
    #define KERN_INFO KERN_SOH "6" /* informational */
                      ^~~~~~~~
   include/linux/printk.h:299:9: note: in expansion of macro 'KERN_INFO'
     printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
            ^~~~~~~~~
   drivers/net/ethernet/dwc/stmmac/dwmac100_core.c:65:2: note: in expansion of macro 'pr_info'
     pr_info("\tVLAN1 tag (offset 0x%x): 0x%08x\n", MAC_VLAN1,
     ^~~~~~~
   include/linux/kern_levels.h:4:18: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'long unsigned int' [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^
   include/linux/kern_levels.h:13:19: note: in expansion of macro 'KERN_SOH'
    #define KERN_INFO KERN_SOH "6" /* informational */
                      ^~~~~~~~
   include/linux/printk.h:299:9: note: in expansion of macro 'KERN_INFO'
     printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
            ^~~~~~~~~
   drivers/net/ethernet/dwc/stmmac/dwmac100_core.c:67:2: note: in expansion of macro 'pr_info'
     pr_info("\tVLAN2 tag (offset 0x%x): 0x%08x\n", MAC_VLAN2,
     ^~~~~~~
--
   In file included from include/linux/kernel.h:13:0,
                    from include/linux/list.h:8,
                    from include/linux/preempt.h:10,
                    from include/linux/spinlock.h:50,
                    from include/linux/phy.h:20,
                    from drivers/net/ethernet/dwc/stmmac/dwmac100.h:28,
                    from drivers/net/ethernet/dwc/stmmac/dwmac100_dma.c:32:
   drivers/net/ethernet/dwc/stmmac/dwmac100_dma.c: In function 'dwmac100_dump_dma_regs':
quoted
drivers/net/ethernet/dwc/stmmac/dwmac100_dma.c:79:12: warning: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'long unsigned int' [-Wformat=]
      pr_debug("\t CSR%d (offset 0x%x): 0x%08x\n", i,
               ^
   include/linux/printk.h:276:21: note: in definition of macro 'pr_fmt'
    #define pr_fmt(fmt) fmt
                        ^~~
   include/linux/printk.h:324:2: note: in expansion of macro 'dynamic_pr_debug'
     dynamic_pr_debug(fmt, ##__VA_ARGS__)
     ^~~~~~~~~~~~~~~~
quoted
drivers/net/ethernet/dwc/stmmac/dwmac100_dma.c:79:3: note: in expansion of macro 'pr_debug'
      pr_debug("\t CSR%d (offset 0x%x): 0x%08x\n", i,
      ^~~~~~~~
   drivers/net/ethernet/dwc/stmmac/dwmac100_dma.c:83:11: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'long unsigned int' [-Wformat=]
     pr_debug("\tCSR20 (0x%x): 0x%08x, CSR21 (0x%x): 0x%08x\n",
              ^
   include/linux/printk.h:276:21: note: in definition of macro 'pr_fmt'
    #define pr_fmt(fmt) fmt
                        ^~~
   include/linux/printk.h:324:2: note: in expansion of macro 'dynamic_pr_debug'
     dynamic_pr_debug(fmt, ##__VA_ARGS__)
     ^~~~~~~~~~~~~~~~
   drivers/net/ethernet/dwc/stmmac/dwmac100_dma.c:83:2: note: in expansion of macro 'pr_debug'
     pr_debug("\tCSR20 (0x%x): 0x%08x, CSR21 (0x%x): 0x%08x\n",
     ^~~~~~~~
   drivers/net/ethernet/dwc/stmmac/dwmac100_dma.c:83:11: warning: format '%x' expects argument of type 'unsigned int', but argument 6 has type 'long unsigned int' [-Wformat=]
     pr_debug("\tCSR20 (0x%x): 0x%08x, CSR21 (0x%x): 0x%08x\n",
              ^
   include/linux/printk.h:276:21: note: in definition of macro 'pr_fmt'
    #define pr_fmt(fmt) fmt
                        ^~~
   include/linux/printk.h:324:2: note: in expansion of macro 'dynamic_pr_debug'
     dynamic_pr_debug(fmt, ##__VA_ARGS__)
     ^~~~~~~~~~~~~~~~
   drivers/net/ethernet/dwc/stmmac/dwmac100_dma.c:83:2: note: in expansion of macro 'pr_debug'
     pr_debug("\tCSR20 (0x%x): 0x%08x, CSR21 (0x%x): 0x%08x\n",
     ^~~~~~~~
--
   In file included from include/linux/kernel.h:13:0,
                    from include/asm-generic/bug.h:13,
                    from arch/m32r/include/asm/bug.h:3,
                    from include/linux/bug.h:4,
                    from include/linux/io.h:23,
                    from drivers/net/ethernet/dwc/stmmac/dwmac4_dma.c:16:
   drivers/net/ethernet/dwc/stmmac/dwmac4_dma.c: In function '_dwmac4_dump_dma_regs':
quoted
drivers/net/ethernet/dwc/stmmac/dwmac4_dma.c:133:11: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'long unsigned int' [-Wformat=]
     pr_debug("\tDMA_CHAN_CONTROL, offset: 0x%x, val: 0x%x\n", 0,
              ^
   include/linux/printk.h:276:21: note: in definition of macro 'pr_fmt'
    #define pr_fmt(fmt) fmt
                        ^~~
   include/linux/printk.h:324:2: note: in expansion of macro 'dynamic_pr_debug'
     dynamic_pr_debug(fmt, ##__VA_ARGS__)
     ^~~~~~~~~~~~~~~~
quoted
drivers/net/ethernet/dwc/stmmac/dwmac4_dma.c:133:2: note: in expansion of macro 'pr_debug'
     pr_debug("\tDMA_CHAN_CONTROL, offset: 0x%x, val: 0x%x\n", 0,
     ^~~~~~~~
   drivers/net/ethernet/dwc/stmmac/dwmac4_dma.c:135:11: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'long unsigned int' [-Wformat=]
     pr_debug("\tDMA_CHAN_TX_CONTROL, offset: 0x%x, val: 0x%x\n", 0x4,
              ^
   include/linux/printk.h:276:21: note: in definition of macro 'pr_fmt'
    #define pr_fmt(fmt) fmt
                        ^~~
   include/linux/printk.h:324:2: note: in expansion of macro 'dynamic_pr_debug'
     dynamic_pr_debug(fmt, ##__VA_ARGS__)
     ^~~~~~~~~~~~~~~~
   drivers/net/ethernet/dwc/stmmac/dwmac4_dma.c:135:2: note: in expansion of macro 'pr_debug'
     pr_debug("\tDMA_CHAN_TX_CONTROL, offset: 0x%x, val: 0x%x\n", 0x4,
     ^~~~~~~~
   drivers/net/ethernet/dwc/stmmac/dwmac4_dma.c:137:11: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'long unsigned int' [-Wformat=]
     pr_debug("\tDMA_CHAN_RX_CONTROL, offset: 0x%x, val: 0x%x\n", 0x8,
              ^
   include/linux/printk.h:276:21: note: in definition of macro 'pr_fmt'
    #define pr_fmt(fmt) fmt
                        ^~~
   include/linux/printk.h:324:2: note: in expansion of macro 'dynamic_pr_debug'
     dynamic_pr_debug(fmt, ##__VA_ARGS__)
     ^~~~~~~~~~~~~~~~
   drivers/net/ethernet/dwc/stmmac/dwmac4_dma.c:137:2: note: in expansion of macro 'pr_debug'
     pr_debug("\tDMA_CHAN_RX_CONTROL, offset: 0x%x, val: 0x%x\n", 0x8,
     ^~~~~~~~
   drivers/net/ethernet/dwc/stmmac/dwmac4_dma.c:139:11: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'long unsigned int' [-Wformat=]
     pr_debug("\tDMA_CHAN_TX_BASE_ADDR, offset: 0x%x, val: 0x%x\n", 0x14,
              ^
   include/linux/printk.h:276:21: note: in definition of macro 'pr_fmt'
    #define pr_fmt(fmt) fmt
                        ^~~
   include/linux/printk.h:324:2: note: in expansion of macro 'dynamic_pr_debug'
     dynamic_pr_debug(fmt, ##__VA_ARGS__)
     ^~~~~~~~~~~~~~~~
   drivers/net/ethernet/dwc/stmmac/dwmac4_dma.c:139:2: note: in expansion of macro 'pr_debug'
     pr_debug("\tDMA_CHAN_TX_BASE_ADDR, offset: 0x%x, val: 0x%x\n", 0x14,
     ^~~~~~~~
   drivers/net/ethernet/dwc/stmmac/dwmac4_dma.c:141:11: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'long unsigned int' [-Wformat=]
     pr_debug("\tDMA_CHAN_RX_BASE_ADDR, offset: 0x%x, val: 0x%x\n", 0x1c,
              ^
   include/linux/printk.h:276:21: note: in definition of macro 'pr_fmt'
    #define pr_fmt(fmt) fmt
                        ^~~
   include/linux/printk.h:324:2: note: in expansion of macro 'dynamic_pr_debug'
     dynamic_pr_debug(fmt, ##__VA_ARGS__)
     ^~~~~~~~~~~~~~~~
   drivers/net/ethernet/dwc/stmmac/dwmac4_dma.c:141:2: note: in expansion of macro 'pr_debug'
     pr_debug("\tDMA_CHAN_RX_BASE_ADDR, offset: 0x%x, val: 0x%x\n", 0x1c,
     ^~~~~~~~
   drivers/net/ethernet/dwc/stmmac/dwmac4_dma.c:143:11: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'long unsigned int' [-Wformat=]
     pr_debug("\tDMA_CHAN_TX_END_ADDR, offset: 0x%x, val: 0x%x\n", 0x20,
              ^
   include/linux/printk.h:276:21: note: in definition of macro 'pr_fmt'
    #define pr_fmt(fmt) fmt
                        ^~~
   include/linux/printk.h:324:2: note: in expansion of macro 'dynamic_pr_debug'
     dynamic_pr_debug(fmt, ##__VA_ARGS__)
     ^~~~~~~~~~~~~~~~
   drivers/net/ethernet/dwc/stmmac/dwmac4_dma.c:143:2: note: in expansion of macro 'pr_debug'
     pr_debug("\tDMA_CHAN_TX_END_ADDR, offset: 0x%x, val: 0x%x\n", 0x20,
     ^~~~~~~~
   drivers/net/ethernet/dwc/stmmac/dwmac4_dma.c:145:11: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'long unsigned int' [-Wformat=]
     pr_debug("\tDMA_CHAN_RX_END_ADDR, offset: 0x%x, val: 0x%x\n", 0x28,
              ^
   include/linux/printk.h:276:21: note: in definition of macro 'pr_fmt'
    #define pr_fmt(fmt) fmt
                        ^~~
   include/linux/printk.h:324:2: note: in expansion of macro 'dynamic_pr_debug'
     dynamic_pr_debug(fmt, ##__VA_ARGS__)
     ^~~~~~~~~~~~~~~~
   drivers/net/ethernet/dwc/stmmac/dwmac4_dma.c:145:2: note: in expansion of macro 'pr_debug'
     pr_debug("\tDMA_CHAN_RX_END_ADDR, offset: 0x%x, val: 0x%x\n", 0x28,
     ^~~~~~~~
   drivers/net/ethernet/dwc/stmmac/dwmac4_dma.c:147:11: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'long unsigned int' [-Wformat=]
     pr_debug("\tDMA_CHAN_TX_RING_LEN, offset: 0x%x, val: 0x%x\n", 0x2c,
              ^
   include/linux/printk.h:276:21: note: in definition of macro 'pr_fmt'
    #define pr_fmt(fmt) fmt
                        ^~~
   include/linux/printk.h:324:2: note: in expansion of macro 'dynamic_pr_debug'
     dynamic_pr_debug(fmt, ##__VA_ARGS__)
     ^~~~~~~~~~~~~~~~
   drivers/net/ethernet/dwc/stmmac/dwmac4_dma.c:147:2: note: in expansion of macro 'pr_debug'
     pr_debug("\tDMA_CHAN_TX_RING_LEN, offset: 0x%x, val: 0x%x\n", 0x2c,
     ^~~~~~~~
   drivers/net/ethernet/dwc/stmmac/dwmac4_dma.c:149:11: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'long unsigned int' [-Wformat=]
     pr_debug("\tDMA_CHAN_RX_RING_LEN, offset: 0x%x, val: 0x%x\n", 0x30,
              ^
   include/linux/printk.h:276:21: note: in definition of macro 'pr_fmt'
    #define pr_fmt(fmt) fmt
                        ^~~
   include/linux/printk.h:324:2: note: in expansion of macro 'dynamic_pr_debug'
     dynamic_pr_debug(fmt, ##__VA_ARGS__)
     ^~~~~~~~~~~~~~~~
   drivers/net/ethernet/dwc/stmmac/dwmac4_dma.c:149:2: note: in expansion of macro 'pr_debug'
     pr_debug("\tDMA_CHAN_RX_RING_LEN, offset: 0x%x, val: 0x%x\n", 0x30,
     ^~~~~~~~
   drivers/net/ethernet/dwc/stmmac/dwmac4_dma.c:151:11: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'long unsigned int' [-Wformat=]
     pr_debug("\tDMA_CHAN_INTR_ENA, offset: 0x%x, val: 0x%x\n", 0x34,
..

vim +/pr_info +107 drivers/net/ethernet/dwc/stmmac/dwmac1000_core.c

d2afb5bd drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c Giuseppe CAVALLARO 2014-09-01   91  
ebbb293f drivers/net/stmmac/dwmac1000_core.c                  Giuseppe CAVALLARO 2010-09-17   92  	writel(value, ioaddr + GMAC_CONTROL);
ebbb293f drivers/net/stmmac/dwmac1000_core.c                  Giuseppe CAVALLARO 2010-09-17   93  
ebbb293f drivers/net/stmmac/dwmac1000_core.c                  Giuseppe CAVALLARO 2010-09-17   94  	value = readl(ioaddr + GMAC_CONTROL);
ebbb293f drivers/net/stmmac/dwmac1000_core.c                  Giuseppe CAVALLARO 2010-09-17   95  
ebbb293f drivers/net/stmmac/dwmac1000_core.c                  Giuseppe CAVALLARO 2010-09-17   96  	return !!(value & GMAC_CONTROL_IPC);
ebbb293f drivers/net/stmmac/dwmac1000_core.c                  Giuseppe CAVALLARO 2010-09-17   97  }
ebbb293f drivers/net/stmmac/dwmac1000_core.c                  Giuseppe CAVALLARO 2010-09-17   98  
7ed24bbe drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c Vince Bridgers     2014-07-31   99  static void dwmac1000_dump_regs(struct mac_device_info *hw)
21d437cc drivers/net/stmmac/dwmac1000_core.c                  Giuseppe CAVALLARO 2010-01-06  100  {
7ed24bbe drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c Vince Bridgers     2014-07-31  101  	void __iomem *ioaddr = hw->pcsr;
21d437cc drivers/net/stmmac/dwmac1000_core.c                  Giuseppe CAVALLARO 2010-01-06  102  	int i;
1f0f6388 drivers/net/stmmac/dwmac1000_core.c                  David S. Miller    2010-08-30  103  	pr_info("\tDWMAC1000 regs (base addr = 0x%p)\n", ioaddr);
21d437cc drivers/net/stmmac/dwmac1000_core.c                  Giuseppe CAVALLARO 2010-01-06  104  
21d437cc drivers/net/stmmac/dwmac1000_core.c                  Giuseppe CAVALLARO 2010-01-06  105  	for (i = 0; i < 55; i++) {
21d437cc drivers/net/stmmac/dwmac1000_core.c                  Giuseppe CAVALLARO 2010-01-06  106  		int offset = i * 4;
21d437cc drivers/net/stmmac/dwmac1000_core.c                  Giuseppe CAVALLARO 2010-01-06 @107  		pr_info("\tReg No. %d (offset 0x%x): 0x%08x\n", i,
21d437cc drivers/net/stmmac/dwmac1000_core.c                  Giuseppe CAVALLARO 2010-01-06  108  			offset, readl(ioaddr + offset));
21d437cc drivers/net/stmmac/dwmac1000_core.c                  Giuseppe CAVALLARO 2010-01-06  109  	}
21d437cc drivers/net/stmmac/dwmac1000_core.c                  Giuseppe CAVALLARO 2010-01-06  110  }
21d437cc drivers/net/stmmac/dwmac1000_core.c                  Giuseppe CAVALLARO 2010-01-06  111  
7ed24bbe drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c Vince Bridgers     2014-07-31  112  static void dwmac1000_set_umac_addr(struct mac_device_info *hw,
7ed24bbe drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c Vince Bridgers     2014-07-31  113  				    unsigned char *addr,
21d437cc drivers/net/stmmac/dwmac1000_core.c                  Giuseppe CAVALLARO 2010-01-06  114  				    unsigned int reg_n)
21d437cc drivers/net/stmmac/dwmac1000_core.c                  Giuseppe CAVALLARO 2010-01-06  115  {

:::::: The code at line 107 was first introduced by commit
:::::: 21d437cc66dcfd0119a4905214fbbe19f3e276dc stmmac: rename the gmac as dwmac1000 and split core and dma parts

:::::: TO: Giuseppe CAVALLARO [off-list ref]
:::::: CC: David S. Miller [off-list ref]

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Re: [PATCH] stmicro: rename it to dwc to improve future development

From: Joao Pinto <hidden>
Date: 2017-01-17 10:17:10 

Hello,

Às 6:58 PM de 1/16/2017, David Miller escreveu:
From: Joao Pinto <redacted>
Date: Mon, 16 Jan 2017 13:26:31 +0000
quoted
The goal of this patch is to create an oficial Designware Ethernet place
to deploy new drivers based on this family of IPs. stmmac was left
untouched since it is a designware based driver. New ethernet designware
IP based drivers should be placed in this place, improving code organization
and it becomes clear to the kernel user the purpose and scope of each driver.

Signed-off-by: Joao Pinto <redacted>
Sorry, I am not applying this.

This would mean that every single -stable backport of a fix to this
driver would require fixing up the directory and/or file name of every
single change without any exception.

This is an unreasonable burdon to put upon me, and every single person
who has to backport bug fixes into older releases of the kernel.

Please stop submitting this rename change.  It is fine to leave the
driver with the stmmac name, and there is zero user benefit to the
rename and only negatives for people who have to work on backports.

I saw no agreement reached between yourself and anyone who voiced
opposition to this driver rename.  Therefore it was entirely
inappropriate for you to resubmit this change again.
Just submited an alternative to the initial rename patch with 0 impact to
STMicroelectronics, so I tried to find a better solution.

I respect your decision.

A new Designware Ethernet IP title driver is being developed at this moment.
Could you please suggest a suitable place to put it, in order to avoid problems
when we reach the upstream phase?

Thanks.

I heard very clearly your argument that you would help with the problem
with the backports, but that is a completely empty gesture.  Here's why.

You cannot help with the problem, nor can any other developer working
on this driver.  People all over the world are going to want to
backport this patch or that, and I myself work in my own little
routine and can't depend on having to have a back and forth with you
over and over again for every single fix to this driver I decide is
reasonable for a -stable backport.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help