[PATCH net-next] liquidio: remove unnecessary code

Subsystems: cavium liquidio network driver, networking drivers, the rest

STALE3508d

2 messages, 2 authors, 2017-01-12 · open the first message on its own page

[PATCH net-next] liquidio: remove unnecessary code

From: Felix Manlunas <hidden>
Date: 2017-01-12 01:10:03

Remove code that's no longer needed.  It used to serve a purpose, which was
to fix a link-related bug.  For a while now, the NIC firmware has had a
more elegant fix for that bug.

Signed-off-by: Felix Manlunas <redacted>
Signed-off-by: Derek Chickles <redacted>
Signed-off-by: Satanand Burla <redacted>
---
 drivers/net/ethernet/cavium/liquidio/lio_main.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet/cavium/liquidio/lio_main.c
index b8b579d..cc825d5 100644
--- a/drivers/net/ethernet/cavium/liquidio/lio_main.c
+++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c
@@ -2693,13 +2693,7 @@ static int liquidio_stop(struct net_device *netdev)
 	lio->linfo.link.s.link_up = 0;
 	lio->link_changes++;
 
-	/* Pause for a moment and wait for Octeon to flush out (to the wire) any
-	 * egress packets that are in-flight.
-	 */
-	set_current_state(TASK_INTERRUPTIBLE);
-	schedule_timeout(msecs_to_jiffies(100));
-
-	/* Now it should be safe to tell Octeon that nic interface is down. */
+	/* Tell Octeon that nic interface is down. */
 	send_rx_ctrl_cmd(lio, 0);
 
 	if (OCTEON_CN23XX_PF(oct)) {

Re: [PATCH net-next] liquidio: remove unnecessary code

From: David Miller <davem@davemloft.net>
Date: 2017-01-12 20:26:01

From: Felix Manlunas <redacted>
Date: Wed, 11 Jan 2017 17:09:02 -0800
Remove code that's no longer needed.  It used to serve a purpose, which was
to fix a link-related bug.  For a while now, the NIC firmware has had a
more elegant fix for that bug.

Signed-off-by: Felix Manlunas <redacted>
Signed-off-by: Derek Chickles <redacted>
Signed-off-by: Satanand Burla <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help