[PATCH net-next] liquidio VF: fix incorrect struct being used

Subsystems: cavium liquidio network driver, networking drivers, the rest

STALE3531d

2 messages, 2 authors, 2017-01-06 · open the first message on its own page

[PATCH net-next] liquidio VF: fix incorrect struct being used

From: Felix Manlunas <hidden>
Date: 2017-01-04 19:33:26

From: Prasad Kanneganti <redacted>

The VF driver is using the wrong struct when sending commands to the NIC
firmware, sometimes causing adverse effects in the firmware.  The right
struct is the one that the PF is using, so make the VF use that as well.

Signed-off-by: Prasad Kanneganti <redacted>
Signed-off-by: Felix Manlunas <redacted>
Signed-off-by: Derek Chickles <redacted>
Signed-off-by: Satanand Burla <redacted>
---
 drivers/net/ethernet/cavium/liquidio/octeon_nic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_nic.c b/drivers/net/ethernet/cavium/liquidio/octeon_nic.c
index c3d6a82..0243be8 100644
--- a/drivers/net/ethernet/cavium/liquidio/octeon_nic.c
+++ b/drivers/net/ethernet/cavium/liquidio/octeon_nic.c
@@ -49,7 +49,7 @@ octeon_alloc_soft_command_resp(struct octeon_device    *oct,
 	/* Add in the response related fields. Opcode and Param are already
 	 * there.
 	 */
-	if (OCTEON_CN23XX_PF(oct)) {
+	if (OCTEON_CN23XX_PF(oct) || OCTEON_CN23XX_VF(oct)) {
 		ih3      = (struct octeon_instr_ih3 *)&sc->cmd.cmd3.ih3;
 		rdp     = (struct octeon_instr_rdp *)&sc->cmd.cmd3.rdp;
 		irh     = (struct octeon_instr_irh *)&sc->cmd.cmd3.irh;
@@ -70,7 +70,7 @@ octeon_alloc_soft_command_resp(struct octeon_device    *oct,
 
 	*sc->status_word = COMPLETION_WORD_INIT;
 
-	if (OCTEON_CN23XX_PF(oct))
+	if (OCTEON_CN23XX_PF(oct) || OCTEON_CN23XX_VF(oct))
 		sc->cmd.cmd3.rptr =  sc->dmarptr;
 	else
 		sc->cmd.cmd2.rptr =  sc->dmarptr;

Re: [PATCH net-next] liquidio VF: fix incorrect struct being used

From: David Miller <davem@davemloft.net>
Date: 2017-01-06 20:31:55

From: Felix Manlunas <redacted>
Date: Wed, 4 Jan 2017 11:31:55 -0800
From: Prasad Kanneganti <redacted>

The VF driver is using the wrong struct when sending commands to the NIC
firmware, sometimes causing adverse effects in the firmware.  The right
struct is the one that the PF is using, so make the VF use that as well.

Signed-off-by: Prasad Kanneganti <redacted>
Signed-off-by: Felix Manlunas <redacted>
Signed-off-by: Derek Chickles <redacted>
Signed-off-by: Satanand Burla <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help