[PATCH v2 net-next] dsa:mv88e6xxx: allow address 0x1 in smi_init

Subsystems: marvell 88e6xxx ethernet switch fabric driver, networking drivers, networking [dsa], the rest

STALE3515d REVIEWED: 8 (8M)

1 review trailer (1 from subsystem maintainers).

2 messages, 2 authors, 2017-01-03 · open the first message on its own page

[PATCH v2 net-next] dsa:mv88e6xxx: allow address 0x1 in smi_init

From: Volodymyr Bendiuga <hidden>
Date: 2017-01-03 09:49:51

From: Volodymyr Bendiuga <redacted>

Some devices, such as the mv88e6097 do have ADDR[0] external and so it
is possible to configure the device to use SMI address 0x1. Remove the
restriction, as there are boards using this address.

Signed-off-by: Volodymyr Bendiuga <redacted>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
 drivers/net/dsa/mv88e6xxx/chip.c | 4 ----
 1 file changed, 4 deletions(-)
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index 4da379f..173ea97 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -4234,10 +4234,6 @@ static void mv88e6xxx_phy_destroy(struct mv88e6xxx_chip *chip)
 static int mv88e6xxx_smi_init(struct mv88e6xxx_chip *chip,
 			      struct mii_bus *bus, int sw_addr)
 {
-	/* ADDR[0] pin is unavailable externally and considered zero */
-	if (sw_addr & 0x1)
-		return -EINVAL;
-
 	if (sw_addr == 0)
 		chip->smi_ops = &mv88e6xxx_smi_single_chip_ops;
 	else if (mv88e6xxx_has(chip, MV88E6XXX_FLAGS_MULTI_CHIP))
-- 
2.7.4

Re: [PATCH v2 net-next] dsa:mv88e6xxx: allow address 0x1 in smi_init

From: David Miller <davem@davemloft.net>
Date: 2017-01-03 15:02:23

From: Volodymyr Bendiuga <redacted>
Date: Tue,  3 Jan 2017 10:49:09 +0100
From: Volodymyr Bendiuga <redacted>

Some devices, such as the mv88e6097 do have ADDR[0] external and so it
is possible to configure the device to use SMI address 0x1. Remove the
restriction, as there are boards using this address.

Signed-off-by: Volodymyr Bendiuga <redacted>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help