[PATCH] net_sched: sch_netem: use rb_entry()

Subsystems: netem network emulator, networking [general], tc subsystem, the rest

STALE2619d

2 messages, 2 authors, 2016-12-20 · open the first message on its own page

[PATCH] net_sched: sch_netem: use rb_entry()

From: Geliang Tang <hidden>
Date: 2016-12-20 14:03:50

To make the code clearer, use rb_entry() instead of container_of() to
deal with rbtree.

Signed-off-by: Geliang Tang <redacted>
---
 net/sched/sch_netem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c
index 9f7b380..b7e4097 100644
--- a/net/sched/sch_netem.c
+++ b/net/sched/sch_netem.c
@@ -152,7 +152,7 @@ struct netem_skb_cb {
 
 static struct sk_buff *netem_rb_to_skb(struct rb_node *rb)
 {
-	return container_of(rb, struct sk_buff, rbnode);
+	return rb_entry(rb, struct sk_buff, rbnode);
 }
 
 static inline struct netem_skb_cb *netem_skb_cb(struct sk_buff *skb)
-- 
2.9.3

Re: [PATCH] net_sched: sch_netem: use rb_entry()

From: David Miller <davem@davemloft.net>
Date: 2016-12-20 19:24:49

From: Geliang Tang <redacted>
Date: Tue, 20 Dec 2016 22:02:16 +0800
To make the code clearer, use rb_entry() instead of container_of() to
deal with rbtree.

Signed-off-by: Geliang Tang <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help