# Re: Potential issues (security and otherwise) with the current cgroup-bpf API

- From: Andy Lutomirski \<luto@amacapital.net\>
- Date: 2016-12-20 01:44:06 
- List: netdev
- Page: https://ratatoskr.run/netdev/2016/12/4898103
- Thread: https://ratatoskr.run/linux-api/2016/12/4897252/t.md

```text
On Mon, Dec 19, 2016 at 4:25 PM, Andy Lutomirski [ref] wrote:
> On Mon, Dec 19, 2016 at 4:02 PM, Alexei Starovoitov
> [ref] wrote:
>> you're ignoring use cases I described earlier.
>> In vrf case there is only one ifindex it needs to bind to.
>
> I'm totally lost.  Can you explain what this has to do with the cgroup
> hierarchy?
>

Okay, I figured out what you mean, I think.  You have a handful of vrf
devices.  Let's say they have ifindexes 1 and 2 (and maybe more).

The interesting case happens when you set up /cgroup/a with a bpf
program that binds new sockets to ifindex 1 and /cgroup/a/b with a bpf
program that binds new sockets to ifindex 2.  The question is: what
should happen if you're in /cgroup/a/b?  Presumably, if you do this,
you wanted to end up with ifindex 2.

I think the way it should actually work is that the kernel evaluates
/cgroup/a/b's hook and then /cgroup/a's hook.  Then /cgroup/a (which
is the more privileged hook) gets to make the choice.  If it wants
ifindex 2 to win, it can do (pseudocode):

if (!sk->sk_bound_if)
  sk->sk_bound_if = 1;
```