[PATCH] drivers: net: xgene: initialize slots

Subsystems: applied micro (apm) x-gene soc ethernet driver, networking drivers, the rest

STALE3577d

2 messages, 2 authors, 2016-12-08 · open the first message on its own page

[PATCH] drivers: net: xgene: initialize slots

From: Colin King <hidden>
Date: 2016-12-08 11:18:26

From: Colin Ian King <redacted>

static analysis using cppcheck detected that slots was uninitialized.
Fix this by initializing it to buf_pool->slots - 1

Found using static analysis with CoverityScan, CID #1387620

Fixes: a9380b0f7be818 ("drivers: net: xgene: Add support for Jumbo frame")
Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
index 6c7eea8..899163c 100644
--- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
+++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
@@ -636,6 +636,7 @@ static void xgene_enet_free_pagepool(struct xgene_enet_desc_ring *buf_pool,
 
 	dev = ndev_to_dev(buf_pool->ndev);
 	head = buf_pool->head;
+	slots = buf_pool->slots - 1;
 
 	for (i = 0; i < 4; i++) {
 		frag_size = xgene_enet_get_data_len(le64_to_cpu(desc[i ^ 1]));
-- 
2.10.2

Re: [PATCH] drivers: net: xgene: initialize slots

From: Iyappan Subramanian <hidden>
Date: 2016-12-08 18:44:39

On Thu, Dec 8, 2016 at 3:17 AM, Colin King [off-list ref] wrote:
quoted hunk
From: Colin Ian King <redacted>

static analysis using cppcheck detected that slots was uninitialized.
Fix this by initializing it to buf_pool->slots - 1

Found using static analysis with CoverityScan, CID #1387620

Fixes: a9380b0f7be818 ("drivers: net: xgene: Add support for Jumbo frame")
Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
index 6c7eea8..899163c 100644
--- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
+++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
@@ -636,6 +636,7 @@ static void xgene_enet_free_pagepool(struct xgene_enet_desc_ring *buf_pool,

        dev = ndev_to_dev(buf_pool->ndev);
        head = buf_pool->head;
+       slots = buf_pool->slots - 1;

        for (i = 0; i < 4; i++) {
                frag_size = xgene_enet_get_data_len(le64_to_cpu(desc[i ^ 1]));
Thanks, Colin.

Dan Carpenter [off-list ref] posted the fix already and
got accepted.
http://marc.info/?l=linux-netdev&m=148110980224343&w=2
--
2.10.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help