[PATCH] Fixed to checkpatch.pl errors to vlan_dev.c

Subsystems: networking [general], the rest

STALE3565d

2 messages, 2 authors, 2016-12-05 · open the first message on its own page

[PATCH] Fixed to checkpatch.pl errors to vlan_dev.c

From: Ozgur Karatas <hidden>
Date: 2016-12-05 15:42:10

Hello all,

I will solve a checkpatch errors.

Signed-off-by: Ozgur Karatas <redacted>

---
 net/8021q/vlan_dev.c                               |   2 +-
diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
index fbfacd5..2edb495 100644
--- a/net/8021q/vlan_dev.c
+++ b/net/8021q/vlan_dev.c
@@ -738,7 +738,7 @@ static int vlan_dev_netpoll_setup(struct net_device *dev, struct netpoll_info *n

 static void vlan_dev_netpoll_cleanup(struct net_device *dev)
 {
-       struct vlan_dev_priv *vlan= vlan_dev_priv(dev);
+       struct vlan_dev_priv *vlan = vlan_dev_priv(dev);
        struct netpoll *netpoll = vlan->netpoll;

        if (!netpoll)

Re: [PATCH] Fixed to checkpatch.pl errors to vlan_dev.c

From: Stefan Schmidt <hidden>
Date: 2016-12-05 15:49:22

Hello.

On 05/12/16 16:34, Ozgur Karatas wrote:
Hello all,

I will solve a checkpatch errors.

Signed-off-by: Ozgur Karatas <redacted>
The patch itself looks good, but please have a read about having a good 
commit message. I would suggest reading Documentation/SubmittingPatches 
section 14: The canonical patch format

Especially the parts about the subject line and summary.
quoted hunk
---
 net/8021q/vlan_dev.c                               |   2 +-
diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
index fbfacd5..2edb495 100644
--- a/net/8021q/vlan_dev.c
+++ b/net/8021q/vlan_dev.c
@@ -738,7 +738,7 @@ static int vlan_dev_netpoll_setup(struct net_device *dev, struct netpoll_info *n

 static void vlan_dev_netpoll_cleanup(struct net_device *dev)
 {
-       struct vlan_dev_priv *vlan= vlan_dev_priv(dev);
+       struct vlan_dev_priv *vlan = vlan_dev_priv(dev);
        struct netpoll *netpoll = vlan->netpoll;

        if (!netpoll)
regards
Stefan Schmidt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help