[PATCH] net: ethernet: ti: cpdma: use desc_read in chan_process instead of raw read

Subsystems: networking drivers, the rest, ti ethernet switch driver (cpsw)

STALE3565d

3 messages, 3 authors, 2016-12-05 · open the first message on its own page

[PATCH] net: ethernet: ti: cpdma: use desc_read in chan_process instead of raw read

From: Ivan Khoronzhuk <hidden>
Date: 2016-12-03 02:05:33

There is desc_read() macros to read desc fields, so no need to
use __raw_readl();

Signed-off-by: Ivan Khoronzhuk <redacted>
---
Based on net-next/master

 drivers/net/ethernet/ti/davinci_cpdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c
index c776e45..d96dca5 100644
--- a/drivers/net/ethernet/ti/davinci_cpdma.c
+++ b/drivers/net/ethernet/ti/davinci_cpdma.c
@@ -1132,7 +1132,7 @@ static int __cpdma_chan_process(struct cpdma_chan *chan)
 	}
 	desc_dma = desc_phys(pool, desc);
 
-	status	= __raw_readl(&desc->hw_mode);
+	status = desc_read(desc, hw_mode);
 	outlen	= status & 0x7ff;
 	if (status & CPDMA_DESC_OWNER) {
 		chan->stats.busy_dequeue++;
-- 
2.7.4

Re: [PATCH] net: ethernet: ti: cpdma: use desc_read in chan_process instead of raw read

From: Grygorii Strashko <grygorii.strashko@ti.com>
Date: 2016-12-05 18:47:20


On 12/02/2016 08:05 PM, Ivan Khoronzhuk wrote:
There is desc_read() macros to read desc fields, so no need to
use __raw_readl();

Signed-off-by: Ivan Khoronzhuk <redacted>

I'm going to update it all at once as part of [1].

[1] https://lkml.org/lkml/2016/12/1/781
quoted hunk
---
Based on net-next/master

 drivers/net/ethernet/ti/davinci_cpdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c
index c776e45..d96dca5 100644
--- a/drivers/net/ethernet/ti/davinci_cpdma.c
+++ b/drivers/net/ethernet/ti/davinci_cpdma.c
@@ -1132,7 +1132,7 @@ static int __cpdma_chan_process(struct cpdma_chan *chan)
 	}
 	desc_dma = desc_phys(pool, desc);

-	status	= __raw_readl(&desc->hw_mode);
+	status = desc_read(desc, hw_mode);
 	outlen	= status & 0x7ff;
 	if (status & CPDMA_DESC_OWNER) {
 		chan->stats.busy_dequeue++;
-- 
regards,
-grygorii

Re: [PATCH] net: ethernet: ti: cpdma: use desc_read in chan_process instead of raw read

From: David Miller <davem@davemloft.net>
Date: 2016-12-05 19:48:04

From: Grygorii Strashko <grygorii.strashko@ti.com>
Date: Mon, 5 Dec 2016 12:47:16 -0600

On 12/02/2016 08:05 PM, Ivan Khoronzhuk wrote:
quoted
There is desc_read() macros to read desc fields, so no need to
use __raw_readl();

Signed-off-by: Ivan Khoronzhuk <redacted>

I'm going to update it all at once as part of [1].

[1] https://lkml.org/lkml/2016/12/1/781
Ok.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help