[PATCH] net: phy: dp83848: Support ethernet pause frames
Subsystems:
ethernet phy library , networking drivers , the rest
3549d
5 messages,
3 authors,
2016-12-05 · open the first message on its own page
According to the documentation, the PHYs supported by this driver
can also support pause frames. Announce this to be so.
Tested with a TI83822I.
Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com>
---
drivers/net/phy/dp83848.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/dp83848.c b/drivers/net/phy/dp83848.c
index 800b39f..6e4117f 100644
--- a/drivers/net/phy/dp83848.c
+++ b/drivers/net/phy/dp83848.c @@ -88,7 +88,8 @@ MODULE_DEVICE_TABLE(mdio, dp83848_tbl);
. phy_id = _id , \
. phy_id_mask = 0xfffffff0 , \
. name = _name , \
- . features = PHY_BASIC_FEATURES , \+ . features = ( PHY_BASIC_FEATURES | \+ SUPPORTED_Pause | SUPPORTED_Asym_Pause ), \ . flags = PHY_HAS_INTERRUPT , \
\
. soft_reset = genphy_soft_reset , \ --
2.1.4
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
On 12/02/2016 08:22 AM, Jesper Nilsson wrote: According to the documentation, the PHYs supported by this driver
can also support pause frames. Announce this to be so.
Tested with a TI83822I.
Looks like all PHYs supported by this driver do, so:
Acked-by: Andrew F. Davis <redacted>
quoted hunk Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com>
---
drivers/net/phy/dp83848.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/dp83848.c b/drivers/net/phy/dp83848.c
index 800b39f..6e4117f 100644
--- a/drivers/net/phy/dp83848.c
+++ b/drivers/net/phy/dp83848.c @@ -88,7 +88,8 @@ MODULE_DEVICE_TABLE(mdio, dp83848_tbl);
. phy_id = _id , \
. phy_id_mask = 0xfffffff0 , \
. name = _name , \
- . features = PHY_BASIC_FEATURES , \+ . features = ( PHY_BASIC_FEATURES | \+ SUPPORTED_Pause | SUPPORTED_Asym_Pause ), \
Aligning these may look nicer though.
.flags = PHY_HAS_INTERRUPT, \
\
.soft_reset = genphy_soft_reset, \
On Fri, Dec 02, 2016 at 08:35:23AM -0600, Andrew F. Davis wrote: On 12/02/2016 08:22 AM, Jesper Nilsson wrote: quoted According to the documentation, the PHYs supported by this driver
can also support pause frames. Announce this to be so.
Tested with a TI83822I.
Looks like all PHYs supported by this driver do, so:
Acked-by: Andrew F. Davis <redacted>
quoted Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com>
---
drivers/net/phy/dp83848.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/dp83848.c b/drivers/net/phy/dp83848.c
index 800b39f..6e4117f 100644
--- a/drivers/net/phy/dp83848.c
+++ b/drivers/net/phy/dp83848.c @@ -88,7 +88,8 @@ MODULE_DEVICE_TABLE(mdio, dp83848_tbl);
. phy_id = _id , \
. phy_id_mask = 0xfffffff0 , \
. name = _name , \
- . features = PHY_BASIC_FEATURES , \+ . features = ( PHY_BASIC_FEATURES | \+ SUPPORTED_Pause | SUPPORTED_Asym_Pause ), \
Aligning these may look nicer though.
Agreed, will send a v2.
quoted .flags = PHY_HAS_INTERRUPT, \
\
.soft_reset = genphy_soft_reset, \
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
According to the documentation, the PHYs supported by this driver
can also support pause frames. Announce this to be so.
Tested with a TI83822I.
Acked-by: Andrew F. Davis <redacted>
Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com>
---
drivers/net/phy/dp83848.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/dp83848.c b/drivers/net/phy/dp83848.c
index 800b39f..320d0dc 100644
--- a/drivers/net/phy/dp83848.c
+++ b/drivers/net/phy/dp83848.c @@ -88,7 +88,9 @@ MODULE_DEVICE_TABLE(mdio, dp83848_tbl);
. phy_id = _id , \
. phy_id_mask = 0xfffffff0 , \
. name = _name , \
- . features = PHY_BASIC_FEATURES , \+ . features = ( PHY_BASIC_FEATURES | \+ SUPPORTED_Pause | \+ SUPPORTED_Asym_Pause ), \ . flags = PHY_HAS_INTERRUPT , \
\
. soft_reset = genphy_soft_reset , \ --
2.1.4
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
From: Jesper Nilsson <jesper.nilsson@axis.com>
Date: Fri, 2 Dec 2016 15:57:49 +0100
According to the documentation, the PHYs supported by this driver
can also support pause frames. Announce this to be so.
Tested with a TI83822I.
Acked-by: Andrew F. Davis <redacted>
Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com>
Applied to net-next, thanks.