[PATCH] ip: vfinfo: remove code duplication for IFLA_VF_RSS_QUERY_EN

Subsystems: the rest

STALE3548d

3 messages, 3 authors, 2016-12-22 · open the first message on its own page

[PATCH] ip: vfinfo: remove code duplication for IFLA_VF_RSS_QUERY_EN

From: Julien Fortin <hidden>
Date: 2016-12-16 16:36:25

From: Julien Fortin <redacted>

Fixes: 4fb4a10e120b1 ("ipaddress: Print IFLA_VF_QUERY_RSS_EN setting”)

Signed-off-by: Julien Fortin <redacted>
---
 ip/ipaddress.c | 8 --------
 1 file changed, 8 deletions(-)
diff --git a/ip/ipaddress.c b/ip/ipaddress.c
index de64877..400ebb4 100644
--- a/ip/ipaddress.c
+++ b/ip/ipaddress.c
@@ -414,14 +414,6 @@ static void print_vfinfo(FILE *fp, struct rtattr *vfinfo)
 			fprintf(fp, ", query_rss %s",
 			        rss_query->setting ? "on" : "off");
 	}
-	if (vf[IFLA_VF_RSS_QUERY_EN]) {
-		struct ifla_vf_rss_query_en *rss_query =
-			RTA_DATA(vf[IFLA_VF_RSS_QUERY_EN]);
-
-		if (rss_query->setting != -1)
-			fprintf(fp, ", query_rss %s",
-			        rss_query->setting ? "on" : "off");
-	}
 	if (vf[IFLA_VF_STATS] && show_stats)
 		print_vf_stats64(fp, vf[IFLA_VF_STATS]);
 }
-- 
2.11.0

Re: [PATCH] ip: vfinfo: remove code duplication for IFLA_VF_RSS_QUERY_EN

From: Phil Sutter <phil@nwl.cc>
Date: 2016-12-16 16:43:13

On Fri, Dec 16, 2016 at 05:36:05PM +0100, Julien Fortin wrote:
From: Julien Fortin <redacted>

Fixes: 4fb4a10e120b1 ("ipaddress: Print IFLA_VF_QUERY_RSS_EN setting”)

Signed-off-by: Julien Fortin <redacted>
Oh! Looks like Git messed up during a rebase and the obviously wrong
result was overlooked.

Acked-by: Phil Sutter <phil@nwl.cc>

Re: [PATCH] ip: vfinfo: remove code duplication for IFLA_VF_RSS_QUERY_EN

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2016-12-22 00:05:11

On Fri, 16 Dec 2016 17:36:05 +0100
Julien Fortin [off-list ref] wrote:
From: Julien Fortin <redacted>

Fixes: 4fb4a10e120b1 ("ipaddress: Print IFLA_VF_QUERY_RSS_EN setting”)

Signed-off-by: Julien Fortin <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help