Re: [PATCH] net: wan: Use dma_pool_zalloc

7 messages, 2 authors, 2016-12-17 · open the first message on its own page

Re: [PATCH] net: wan: Use dma_pool_zalloc

From: Souptick Joarder <hidden>
Date: 2016-12-12 04:42:40 

On Fri, Dec 9, 2016 at 6:33 PM, Krzysztof Hałasa [off-list ref] wrote:
Souptick Joarder [off-list ref] writes:
quoted
We should use dma_pool_zalloc instead of dma_pool_alloc/memset

Signed-off-by: Souptick joarder <redacted>
---
 drivers/net/wan/ixp4xx_hss.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wan/ixp4xx_hss.c b/drivers/net/wan/ixp4xx_hss.c
index e7bbdb7..aaabf31 100644
--- a/drivers/net/wan/ixp4xx_hss.c
+++ b/drivers/net/wan/ixp4xx_hss.c
@@ -976,10 +976,9 @@ static int init_hdlc_queues(struct port *port)
                      return -ENOMEM;
      }

-     if (!(port->desc_tab = dma_pool_alloc(dma_pool, GFP_KERNEL,
-                                           &port->desc_tab_phys)))
+     if (!(port->desc_tab = dma_pool_zalloc(dma_pool, GFP_KERNEL,
+                                            &port->desc_tab_phys)))
              return -ENOMEM;
-     memset(port->desc_tab, 0, POOL_ALLOC_SIZE);
      memset(port->rx_buff_tab, 0, sizeof(port->rx_buff_tab)); /* tables */
      memset(port->tx_buff_tab, 0, sizeof(port->tx_buff_tab));
This look fine, feel free to send it to the netdev mailing list for
inclusion.
Including netdev mailing list based as requested.

Acked-by: Krzysztof Halasa <khalasa@piap.pl>
--
Krzysztof Halasa

Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland

Re: [PATCH] net: wan: Use dma_pool_zalloc

From: Souptick Joarder <hidden>
Date: 2016-12-15 05:28:07 

On Mon, Dec 12, 2016 at 10:12 AM, Souptick Joarder [off-list ref] wrote:
On Fri, Dec 9, 2016 at 6:33 PM, Krzysztof Hałasa [off-list ref] wrote:
quoted
Souptick Joarder [off-list ref] writes:
quoted
We should use dma_pool_zalloc instead of dma_pool_alloc/memset

Signed-off-by: Souptick joarder <redacted>
---
 drivers/net/wan/ixp4xx_hss.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wan/ixp4xx_hss.c b/drivers/net/wan/ixp4xx_hss.c
index e7bbdb7..aaabf31 100644
--- a/drivers/net/wan/ixp4xx_hss.c
+++ b/drivers/net/wan/ixp4xx_hss.c
@@ -976,10 +976,9 @@ static int init_hdlc_queues(struct port *port)
                      return -ENOMEM;
      }

-     if (!(port->desc_tab = dma_pool_alloc(dma_pool, GFP_KERNEL,
-                                           &port->desc_tab_phys)))
+     if (!(port->desc_tab = dma_pool_zalloc(dma_pool, GFP_KERNEL,
+                                            &port->desc_tab_phys)))
              return -ENOMEM;
-     memset(port->desc_tab, 0, POOL_ALLOC_SIZE);
      memset(port->rx_buff_tab, 0, sizeof(port->rx_buff_tab)); /* tables */
      memset(port->tx_buff_tab, 0, sizeof(port->tx_buff_tab));
This look fine, feel free to send it to the netdev mailing list for
inclusion.
Including netdev mailing list based as requested.
quoted
Acked-by: Krzysztof Halasa <khalasa@piap.pl>
--
Krzysztof Halasa

Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
Any comment on this patch ?

Re: [PATCH] net: wan: Use dma_pool_zalloc

From: Joe Perches <joe@perches.com>
Date: 2016-12-15 16:48:12 

On Thu, 2016-12-15 at 10:41 +0530, Souptick Joarder wrote:
On Mon, Dec 12, 2016 at 10:12 AM, Souptick Joarder [off-list ref] wrote:
quoted
On Fri, Dec 9, 2016 at 6:33 PM, Krzysztof Hałasa [off-list ref] wrote:
quoted
Souptick Joarder [off-list ref] writes:
quoted
We should use dma_pool_zalloc instead of dma_pool_alloc/memset
[]
quoted
quoted
quoted
diff --git a/drivers/net/wan/ixp4xx_hss.c b/drivers/net/wan/ixp4xx_hss.c
[]
quoted
quoted
quoted
@@ -976,10 +976,9 @@ static int init_hdlc_queues(struct port *port)
                      return -ENOMEM;
      }

-     if (!(port->desc_tab = dma_pool_alloc(dma_pool, GFP_KERNEL,
-                                           &port->desc_tab_phys)))
+     if (!(port->desc_tab = dma_pool_zalloc(dma_pool, GFP_KERNEL,
+                                            &port->desc_tab_phys)))
              return -ENOMEM;
-     memset(port->desc_tab, 0, POOL_ALLOC_SIZE);
      memset(port->rx_buff_tab, 0, sizeof(port->rx_buff_tab)); /* tables */
      memset(port->tx_buff_tab, 0, sizeof(port->tx_buff_tab));
This look fine, feel free to send it to the netdev mailing list for
inclusion.
Including netdev mailing list based as requested.
quoted
Acked-by: Krzysztof Halasa <khalasa@piap.pl>
[]
Any comment on this patch ?
Shouldn't the one in drivers/net/ethernet/xscale/ixp4xx_eth.c
also be changed?

Re: [PATCH] net: wan: Use dma_pool_zalloc

From: Joe Perches <joe@perches.com>
Date: 2016-12-16 06:11:56 

On Fri, 2016-12-16 at 11:33 +0530, Souptick Joarder wrote:
On Thu, Dec 15, 2016 at 10:18 PM, Joe Perches [off-list ref] wrote:
quoted
On Thu, 2016-12-15 at 10:41 +0530, Souptick Joarder wrote:
quoted
On Mon, Dec 12, 2016 at 10:12 AM, Souptick Joarder [off-list ref] wrote:
quoted
On Fri, Dec 9, 2016 at 6:33 PM, Krzysztof Hałasa [off-list ref] wrote:
quoted
Souptick Joarder [off-list ref] writes:
quoted
We should use dma_pool_zalloc instead of dma_pool_alloc/memset
[]
quoted
quoted
quoted
quoted
diff --git a/drivers/net/wan/ixp4xx_hss.c b/drivers/net/wan/ixp4xx_hss.c
[]
quoted
quoted
quoted
quoted
@@ -976,10 +976,9 @@ static int init_hdlc_queues(struct port *port)
                      return -ENOMEM;
      }

-     if (!(port->desc_tab = dma_pool_alloc(dma_pool, GFP_KERNEL,
-                                           &port->desc_tab_phys)))
+     if (!(port->desc_tab = dma_pool_zalloc(dma_pool, GFP_KERNEL,
+                                            &port->desc_tab_phys)))
              return -ENOMEM;
-     memset(port->desc_tab, 0, POOL_ALLOC_SIZE);
      memset(port->rx_buff_tab, 0, sizeof(port->rx_buff_tab)); /* tables */
      memset(port->tx_buff_tab, 0, sizeof(port->tx_buff_tab));
This look fine, feel free to send it to the netdev mailing list for
inclusion.
Including netdev mailing list based as requested.
quoted
Acked-by: Krzysztof Halasa <khalasa@piap.pl>
[]
quoted
Any comment on this patch ?
Shouldn't the one in drivers/net/ethernet/xscale/ixp4xx_eth.c
also be changed?
Yes, you are right.   Do you want me to include it in same patch?
Your choice.  I would use a single patch.

Re: [PATCH] net: wan: Use dma_pool_zalloc

From: Souptick Joarder <hidden>
Date: 2016-12-16 06:29:33 

On Thu, Dec 15, 2016 at 10:18 PM, Joe Perches [off-list ref] wrote:
On Thu, 2016-12-15 at 10:41 +0530, Souptick Joarder wrote:
quoted
On Mon, Dec 12, 2016 at 10:12 AM, Souptick Joarder [off-list ref] wrote:
quoted
On Fri, Dec 9, 2016 at 6:33 PM, Krzysztof Hałasa [off-list ref] wrote:
quoted
Souptick Joarder [off-list ref] writes:
quoted
We should use dma_pool_zalloc instead of dma_pool_alloc/memset
[]
quoted
quoted
quoted
quoted
diff --git a/drivers/net/wan/ixp4xx_hss.c b/drivers/net/wan/ixp4xx_hss.c
[]
quoted
quoted
quoted
quoted
@@ -976,10 +976,9 @@ static int init_hdlc_queues(struct port *port)
                      return -ENOMEM;
      }

-     if (!(port->desc_tab = dma_pool_alloc(dma_pool, GFP_KERNEL,
-                                           &port->desc_tab_phys)))
+     if (!(port->desc_tab = dma_pool_zalloc(dma_pool, GFP_KERNEL,
+                                            &port->desc_tab_phys)))
              return -ENOMEM;
-     memset(port->desc_tab, 0, POOL_ALLOC_SIZE);
      memset(port->rx_buff_tab, 0, sizeof(port->rx_buff_tab)); /* tables */
      memset(port->tx_buff_tab, 0, sizeof(port->tx_buff_tab));
This look fine, feel free to send it to the netdev mailing list for
inclusion.
Including netdev mailing list based as requested.
quoted
Acked-by: Krzysztof Halasa <khalasa@piap.pl>
[]
quoted
Any comment on this patch ?
Shouldn't the one in drivers/net/ethernet/xscale/ixp4xx_eth.c
also be changed?
Yes, you are right.   Do you want me to include it in same patch?

Regards
Souptick

Re: [PATCH] net: wan: Use dma_pool_zalloc

From: Souptick Joarder <hidden>
Date: 2016-12-16 13:55:48 

On Fri, Dec 16, 2016 at 11:40 AM, Joe Perches [off-list ref] wrote:
On Fri, 2016-12-16 at 11:33 +0530, Souptick Joarder wrote:
quoted
On Thu, Dec 15, 2016 at 10:18 PM, Joe Perches [off-list ref] wrote:
quoted
On Thu, 2016-12-15 at 10:41 +0530, Souptick Joarder wrote:
quoted
On Mon, Dec 12, 2016 at 10:12 AM, Souptick Joarder [off-list ref] wrote:
quoted
On Fri, Dec 9, 2016 at 6:33 PM, Krzysztof Hałasa [off-list ref] wrote:
quoted
Souptick Joarder [off-list ref] writes:
quoted
We should use dma_pool_zalloc instead of dma_pool_alloc/memset
[]
quoted
quoted
quoted
quoted
diff --git a/drivers/net/wan/ixp4xx_hss.c b/drivers/net/wan/ixp4xx_hss.c
[]
quoted
quoted
quoted
quoted
@@ -976,10 +976,9 @@ static int init_hdlc_queues(struct port *port)
                      return -ENOMEM;
      }

-     if (!(port->desc_tab = dma_pool_alloc(dma_pool, GFP_KERNEL,
-                                           &port->desc_tab_phys)))
+     if (!(port->desc_tab = dma_pool_zalloc(dma_pool, GFP_KERNEL,
+                                            &port->desc_tab_phys)))
              return -ENOMEM;
-     memset(port->desc_tab, 0, POOL_ALLOC_SIZE);
      memset(port->rx_buff_tab, 0, sizeof(port->rx_buff_tab)); /* tables */
      memset(port->tx_buff_tab, 0, sizeof(port->tx_buff_tab));
This look fine, feel free to send it to the netdev mailing list for
inclusion.
Including netdev mailing list based as requested.
quoted
Acked-by: Krzysztof Halasa <khalasa@piap.pl>
[]
quoted
Any comment on this patch ?
Shouldn't the one in drivers/net/ethernet/xscale/ixp4xx_eth.c
also be changed?
Yes, you are right.   Do you want me to include it in same patch?
Your choice.  I would use a single patch.
There are few other places where the same change is applicable.
I am planning to put all those changes in a single patch. It includes
changes in drivers/net/ethernet/xscale/ixp4xx_eth.c

You can review this patch separately.

Re: [PATCH] net: wan: Use dma_pool_zalloc

From: Joe Perches <joe@perches.com>
Date: 2016-12-17 00:17:23 

On Fri, 2016-12-16 at 19:25 +0530, Souptick Joarder wrote:
On Fri, Dec 16, 2016 at 11:40 AM, Joe Perches [off-list ref] wrote:
quoted
On Fri, 2016-12-16 at 11:33 +0530, Souptick Joarder wrote:
quoted
On Thu, Dec 15, 2016 at 10:18 PM, Joe Perches [off-list ref] wrote:
quoted
On Thu, 2016-12-15 at 10:41 +0530, Souptick Joarder wrote:
quoted
On Mon, Dec 12, 2016 at 10:12 AM, Souptick Joarder [off-list ref] wrote:
quoted
On Fri, Dec 9, 2016 at 6:33 PM, Krzysztof Hałasa [off-list ref] wrote:
quoted
Souptick Joarder [off-list ref] writes:
quoted
We should use dma_pool_zalloc instead of dma_pool_alloc/memset
[]
quoted
quoted
quoted
quoted
diff --git a/drivers/net/wan/ixp4xx_hss.c b/drivers/net/wan/ixp4xx_hss.c
[]
quoted
quoted
quoted
quoted
@@ -976,10 +976,9 @@ static int init_hdlc_queues(struct port *port)
                      return -ENOMEM;
      }

-     if (!(port->desc_tab = dma_pool_alloc(dma_pool, GFP_KERNEL,
-                                           &port->desc_tab_phys)))
+     if (!(port->desc_tab = dma_pool_zalloc(dma_pool, GFP_KERNEL,
+                                            &port->desc_tab_phys)))
              return -ENOMEM;
-     memset(port->desc_tab, 0, POOL_ALLOC_SIZE);
      memset(port->rx_buff_tab, 0, sizeof(port->rx_buff_tab)); /* tables */
      memset(port->tx_buff_tab, 0, sizeof(port->tx_buff_tab));
This look fine, feel free to send it to the netdev mailing list for
inclusion.
Including netdev mailing list based as requested.
quoted
Acked-by: Krzysztof Halasa <khalasa@piap.pl>
[]
quoted
Any comment on this patch ?
Shouldn't the one in drivers/net/ethernet/xscale/ixp4xx_eth.c
also be changed?
Yes, you are right.   Do you want me to include it in same patch?
Your choice.  I would use a single patch.
There are few other places where the same change is applicable.
I am planning to put all those changes in a single patch. It includes
changes in drivers/net/ethernet/xscale/ixp4xx_eth.c

You can review this patch separately.
If you are spanning multiple drivers maintained by different
groups, it's probably better to create a patch series, one for
each driver, to allow the various maintainers to apply the
patches to their individually maintained drivers.

Joe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help