# Re: \[PATCH 1/3\] tools/virtio: fix READ\_ONCE()

- From: Cornelia Huck \<hidden\>
- Date: 2016-11-24 11:35:04 
- List: netdev
- Page: https://ratatoskr.run/netdev/2016/11/4882231
- Thread: https://ratatoskr.run/kvm/2016/11/4882170/t.md

```text
On Thu, 24 Nov 2016 10:25:12 +0000
Mark Rutland [ref] wrote:

> The virtio tools implementation of READ_ONCE() has a single parameter called
> 'var', but erroneously refers to 'val' for its cast, and thus won't work unless
> there's a variable of the correct type that happens to be called 'var'.
> 
> Fix this with s/var/val/, making READ_ONCE() work as expected regardless.
> 
> Fixes: a7c490333df3cff5 ("tools/virtio: use virt_xxx barriers")
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> Cc: Jason Wang <redacted>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Cc: <redacted>
> Cc: <redacted>
> ---
>  tools/virtio/linux/compiler.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Cornelia Huck <redacted>
```
