[PATCH] net: ethernet: faraday: To support device tree usage.

Subsystems: networking drivers, the rest

STALE3550d

7 messages, 3 authors, 2016-11-16 · open the first message on its own page

[PATCH] net: ethernet: faraday: To support device tree usage.

From: Greentime Hu <hidden>
Date: 2016-11-16 09:08:05

To support device tree usage for ftmac100.

Signed-off-by: Greentime Hu <redacted>
---
 drivers/net/ethernet/faraday/ftmac100.c |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/net/ethernet/faraday/ftmac100.c b/drivers/net/ethernet/faraday/ftmac100.c
index dce5f7b..81dd9e1 100644
--- a/drivers/net/ethernet/faraday/ftmac100.c
+++ b/drivers/net/ethernet/faraday/ftmac100.c

@@ -1172,11 +1172,17 @@ static int __exit ftmac100_remove(struct platform_device *pdev)
 	return 0;
 }
 
+static const struct of_device_id mac_of_ids[] = {
+	{ .compatible = "andestech,atmac100" },
+	{ }
+};
+
 static struct platform_driver ftmac100_driver = {
 	.probe		= ftmac100_probe,
 	.remove		= __exit_p(ftmac100_remove),
 	.driver		= {
 		.name	= DRV_NAME,
+		.of_match_table = mac_of_ids
 	},
 };

@@ -1200,3 +1206,4 @@ static void __exit ftmac100_exit(void)
 MODULE_AUTHOR("Po-Yu Chuang <ratbert@faraday-tech.com>");
 MODULE_DESCRIPTION("FTMAC100 driver");
 MODULE_LICENSE("GPL");
+MODULE_DEVICE_TABLE(of, mac_of_ids);

-- 
1.7.9.5

Re: [PATCH] net: ethernet: faraday: To support device tree usage.

From: Jiri Pirko <jiri@resnulli.us>
Date: 2016-11-16 11:53:49

Wed, Nov 16, 2016 at 09:43:15AM CET, green.hu@gmail.com wrote:

quoted hunk

To support device tree usage for ftmac100.

Signed-off-by: Greentime Hu <redacted>
---
drivers/net/ethernet/faraday/ftmac100.c |    7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/net/ethernet/faraday/ftmac100.c b/drivers/net/ethernet/faraday/ftmac100.c
index dce5f7b..81dd9e1 100644
--- a/drivers/net/ethernet/faraday/ftmac100.c
+++ b/drivers/net/ethernet/faraday/ftmac100.c

@@ -1172,11 +1172,17 @@ static int __exit ftmac100_remove(struct platform_device *pdev)

	return 0;
}

+static const struct of_device_id mac_of_ids[] = {

Prefix of everything in this file is "ftmac100", yet here, you use
"mac". I wonder why?!?

quoted hunk

+	{ .compatible = "andestech,atmac100" },
+	{ }
+};
+
static struct platform_driver ftmac100_driver = {
	.probe		= ftmac100_probe,
	.remove		= __exit_p(ftmac100_remove),
	.driver		= {
		.name	= DRV_NAME,
+		.of_match_table = mac_of_ids
	},
};

@@ -1200,3 +1206,4 @@ static void __exit ftmac100_exit(void)

MODULE_AUTHOR("Po-Yu Chuang [off-list ref]");
MODULE_DESCRIPTION("FTMAC100 driver");
MODULE_LICENSE("GPL");
+MODULE_DEVICE_TABLE(of, mac_of_ids);
-- 
1.7.9.5

Re: [PATCH] net: ethernet: faraday: To support device tree usage.

From: Greentime Hu <hidden>
Date: 2016-11-16 12:09:41

You are right. I didn't notice that. I should use ftmac100.

On Wed, Nov 16, 2016 at 7:53 PM, Jiri Pirko [off-list ref] wrote:

Wed, Nov 16, 2016 at 09:43:15AM CET, green.hu@gmail.com wrote:

quoted

To support device tree usage for ftmac100.

Signed-off-by: Greentime Hu <redacted>
---
drivers/net/ethernet/faraday/ftmac100.c |    7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/net/ethernet/faraday/ftmac100.c b/drivers/net/ethernet/faraday/ftmac100.c
index dce5f7b..81dd9e1 100644
--- a/drivers/net/ethernet/faraday/ftmac100.c
+++ b/drivers/net/ethernet/faraday/ftmac100.c

@@ -1172,11 +1172,17 @@ static int __exit ftmac100_remove(struct platform_device *pdev)
      return 0;

}

+static const struct of_device_id mac_of_ids[] = {

Prefix of everything in this file is "ftmac100", yet here, you use
"mac". I wonder why?!?

quoted

+      { .compatible = "andestech,atmac100" },
+      { }
+};
+
static struct platform_driver ftmac100_driver = {
      .probe          = ftmac100_probe,
      .remove         = __exit_p(ftmac100_remove),
      .driver         = {
              .name   = DRV_NAME,
+              .of_match_table = mac_of_ids
      },
};

@@ -1200,3 +1206,4 @@ static void __exit ftmac100_exit(void)

MODULE_AUTHOR("Po-Yu Chuang [off-list ref]");
MODULE_DESCRIPTION("FTMAC100 driver");
MODULE_LICENSE("GPL");
+MODULE_DEVICE_TABLE(of, mac_of_ids);
--
1.7.9.5

Re: [PATCH] net: ethernet: faraday: To support device tree usage.

From: Jiri Pirko <jiri@resnulli.us>
Date: 2016-11-16 12:16:27

Wed, Nov 16, 2016 at 01:08:57PM CET, green.hu@gmail.com wrote:

You are right. I didn't notice that. I should use ftmac100.

Don't top-post please.

On Wed, Nov 16, 2016 at 7:53 PM, Jiri Pirko [off-list ref] wrote:

quoted

Wed, Nov 16, 2016 at 09:43:15AM CET, green.hu@gmail.com wrote:

quoted

To support device tree usage for ftmac100.

Signed-off-by: Greentime Hu <redacted>
---
drivers/net/ethernet/faraday/ftmac100.c |    7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/net/ethernet/faraday/ftmac100.c b/drivers/net/ethernet/faraday/ftmac100.c
index dce5f7b..81dd9e1 100644
--- a/drivers/net/ethernet/faraday/ftmac100.c
+++ b/drivers/net/ethernet/faraday/ftmac100.c

@@ -1172,11 +1172,17 @@ static int __exit ftmac100_remove(struct platform_device *pdev)
      return 0;

}

+static const struct of_device_id mac_of_ids[] = {

Prefix of everything in this file is "ftmac100", yet here, you use
"mac". I wonder why?!?

quoted

+      { .compatible = "andestech,atmac100" },
+      { }
+};
+
static struct platform_driver ftmac100_driver = {
      .probe          = ftmac100_probe,
      .remove         = __exit_p(ftmac100_remove),
      .driver         = {
              .name   = DRV_NAME,
+              .of_match_table = mac_of_ids
      },
};

@@ -1200,3 +1206,4 @@ static void __exit ftmac100_exit(void)

MODULE_AUTHOR("Po-Yu Chuang [off-list ref]");
MODULE_DESCRIPTION("FTMAC100 driver");
MODULE_LICENSE("GPL");
+MODULE_DEVICE_TABLE(of, mac_of_ids);
--
1.7.9.5

Re: [PATCH] net: ethernet: faraday: To support device tree usage.

From: Andrew Lunn <andrew@lunn.ch>
Date: 2016-11-16 13:47:21

On Wed, Nov 16, 2016 at 04:43:15PM +0800, Greentime Hu wrote:

quoted hunk

To support device tree usage for ftmac100.

Signed-off-by: Greentime Hu <redacted>
---
 drivers/net/ethernet/faraday/ftmac100.c |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/net/ethernet/faraday/ftmac100.c b/drivers/net/ethernet/faraday/ftmac100.c
index dce5f7b..81dd9e1 100644
--- a/drivers/net/ethernet/faraday/ftmac100.c
+++ b/drivers/net/ethernet/faraday/ftmac100.c

@@ -1172,11 +1172,17 @@ static int __exit ftmac100_remove(struct platform_device *pdev)
 	return 0;
 }
 
+static const struct of_device_id mac_of_ids[] = {
+	{ .compatible = "andestech,atmac100" },
+	{ }

andestech is not in
Documentation/devicetree/bindings/vendor-prefixes.txt Please provide a
separate patch adding it.

Humm, why andestech? Why not something based around faraday
technology?

      Andrew

Re: [PATCH] net: ethernet: faraday: To support device tree usage.

From: Greentime Hu <hidden>
Date: 2016-11-16 14:27:36

On Wed, Nov 16, 2016 at 9:47 PM, Andrew Lunn [off-list ref] wrote:

On Wed, Nov 16, 2016 at 04:43:15PM +0800, Greentime Hu wrote:

quoted

To support device tree usage for ftmac100.

Signed-off-by: Greentime Hu <redacted>
---
 drivers/net/ethernet/faraday/ftmac100.c |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/net/ethernet/faraday/ftmac100.c b/drivers/net/ethernet/faraday/ftmac100.c
index dce5f7b..81dd9e1 100644
--- a/drivers/net/ethernet/faraday/ftmac100.c
+++ b/drivers/net/ethernet/faraday/ftmac100.c

@@ -1172,11 +1172,17 @@ static int __exit ftmac100_remove(struct platform_device *pdev)
      return 0;
 }

+static const struct of_device_id mac_of_ids[] = {
+     { .compatible = "andestech,atmac100" },
+     { }

andestech is not in
Documentation/devicetree/bindings/vendor-prefixes.txt Please provide a
separate patch adding it.

OK. I will provide another patch to add andestech.

Humm, why andestech? Why not something based around faraday
technology?

It is because we use the same ftmac100 IP provided from faraday
technology but I am now using it in andestech SoC.

Re: [PATCH] net: ethernet: faraday: To support device tree usage.

From: Andrew Lunn <andrew@lunn.ch>
Date: 2016-11-16 14:37:15

On Wed, Nov 16, 2016 at 10:26:52PM +0800, Greentime Hu wrote:

On Wed, Nov 16, 2016 at 9:47 PM, Andrew Lunn [off-list ref] wrote:

quoted

On Wed, Nov 16, 2016 at 04:43:15PM +0800, Greentime Hu wrote:

quoted

To support device tree usage for ftmac100.

Signed-off-by: Greentime Hu <redacted>
---
 drivers/net/ethernet/faraday/ftmac100.c |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/net/ethernet/faraday/ftmac100.c b/drivers/net/ethernet/faraday/ftmac100.c
index dce5f7b..81dd9e1 100644
--- a/drivers/net/ethernet/faraday/ftmac100.c
+++ b/drivers/net/ethernet/faraday/ftmac100.c

@@ -1172,11 +1172,17 @@ static int __exit ftmac100_remove(struct platform_device *pdev)
      return 0;
 }

+static const struct of_device_id mac_of_ids[] = {
+     { .compatible = "andestech,atmac100" },
+     { }

andestech is not in
Documentation/devicetree/bindings/vendor-prefixes.txt Please provide a
separate patch adding it.

OK. I will provide another patch to add andestech.

quoted

Humm, why andestech? Why not something based around faraday
technology?

It is because we use the same ftmac100 IP provided from faraday
technology but I am now using it in andestech SoC.

Please make sure you get an acked-by: from the device tree
maintainers. They might want you to use faraday, since that is the
original IP provider. For example, all Synopsys licensed IP uses
"snps,XXX", not the SoC vendor with the license.

	    Andrew

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help