[PATCH] net: ethernet: ti: davinci_cpdma: don't stop ctlr if it was stopped

Subsystems: networking drivers, the rest, ti ethernet switch driver (cpsw)

STALE3559d

2 messages, 2 authors, 2016-11-13 · open the first message on its own page

[PATCH] net: ethernet: ti: davinci_cpdma: don't stop ctlr if it was stopped

From: Ivan Khoronzhuk <hidden>
Date: 2016-11-11 14:10:56

No need to stop ctlr if it was already stopped. It can cause timeout
warns. Steps:
- ifconfig eth0 down
- ethtool -l eth0 rx 8 tx 8
- ethtool -l eth0 rx 1 tx 1

Signed-off-by: Ivan Khoronzhuk <redacted>
---

Based on net-next/master

 drivers/net/ethernet/ti/davinci_cpdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c
index 56395ce..56708a7 100644
--- a/drivers/net/ethernet/ti/davinci_cpdma.c
+++ b/drivers/net/ethernet/ti/davinci_cpdma.c
@@ -387,7 +387,7 @@ int cpdma_ctlr_stop(struct cpdma_ctlr *ctlr)
 	int i;
 
 	spin_lock_irqsave(&ctlr->lock, flags);
-	if (ctlr->state == CPDMA_STATE_TEARDOWN) {
+	if (ctlr->state != CPDMA_STATE_ACTIVE) {
 		spin_unlock_irqrestore(&ctlr->lock, flags);
 		return -EINVAL;
 	}
-- 
1.9.1

Re: [PATCH] net: ethernet: ti: davinci_cpdma: don't stop ctlr if it was stopped

From: David Miller <davem@davemloft.net>
Date: 2016-11-13 18:40:53

From: Ivan Khoronzhuk <redacted>
Date: Fri, 11 Nov 2016 16:10:47 +0200
No need to stop ctlr if it was already stopped. It can cause timeout
warns. Steps:
- ifconfig eth0 down
- ethtool -l eth0 rx 8 tx 8
- ethtool -l eth0 rx 1 tx 1

Signed-off-by: Ivan Khoronzhuk <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help