# Re: \[PATCH net-next v3 2/2\] net: phy: bcm7xxx: Plug in support for reading PHY error counters

- From: Andrew Lunn \<andrew@lunn.ch\>
- Date: 2016-11-30 13:37:11 
- List: netdev
- Page: https://ratatoskr.run/netdev/2016/11/11036576
- Thread: https://ratatoskr.run/netdev/2016/11/11036416/t.md

```text
On Tue, Nov 29, 2016 at 09:57:18AM -0800, Florian Fainelli wrote:
> Broadcom BCM7xxx internal PHYs can leverage the Broadcom PHY library
> module PHY error counters helper functions, just implement the
> appropriate PHY driver function calls to do so. We need to allocate some
> storage space for our PHY statistics, and provide it to the Broadcom PHY
> library, so do this in a specific probe function, and slightly wrap the
> get_stats function call.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Hi Florian

Nice to see another PHY driver make use of this.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
```